avm2: Move DisplayObject assignment into an initializer

[Aaron1011]

No description provided.

[Lord-McSweeney]

Progresses #11051.

[Lord-McSweeney]

Should Sound also be moved to an instance allocator?

[Aaron1011]

I added a test - it looks like Sound is a 'normal' object (the initialization happens during the super() call, not during the allocator).

[SN902]

I found regression, this commit brings back flickering buttons/sliders in #10208 and PortageCS5.zip

[kmeisthax]

I'm not sure why super_init got removed from Sound and ApplicationDomain - is there some subtlety of initialization I'm missing? I thought they were "normal" (i.e. no native-allocated fields). I try to keep super_init in native code since the AS3 compiler automatically inserts constructsuper everywhere anyway, but this isn't particularly important with EventDispatcher being lazy.

The regression @SN902 found is worth looking into but I won't be able to do that for a few more days. Looking at the original PR #10734 it looks like you correctly carried forward everything from that, so it SHOULDN'T be broken, which suggests that we might need to move the check somewhere else, or set a flag here that play/goto checks for.

[kmeisthax]

My gut feeling is that it should throw, but I'm not going to ask for it to throw until/unless we have tests that go that way.

[kmeisthax]

This title has become a bit of a misnomer now that it just constructs an empty graphic without taking an AVM2 object.

[Aaron1011]

I've renamed this to empty

[kmeisthax]

Same here

[Aaron1011]

I've renamed this to empty

[Aaron1011]

@kmeisthax: The 'super_init' removes were drive by fixes. Those calls were in init methods, which are just normal methods called from the constructor (the super_init call was left over when we defined the class in actionscript).

I discussed the regression on Discord, but forgot to leave a comment on the pr- I fixed it in ad15328 (#11084)

[n0samu]

With this PR, #8947 is occurring again 😦

ERROR run_frame:run_all_phases_avm2: ruffle_core::avm2::events: Error dispatching event EventObject(EventObject { type: "addedToStage", class: flash.events::Event, ptr: 0x218a7850388 }) to handler FunctionObject(FunctionObject { ptr: 0x218a27e0a88 }) : TypeError: Error #1009: Cannot access a property or method of a null object reference. (accessing field: visible)
        at classes::Level/holderOnAddedToStage()
        at flash.display::DisplayObjectContainer/flash::display::DisplayObjectContainer::addChildAt()
        at classes.app::Main/createLevel()
        at classes.app::Main/nextLevel()
        at classes::ShutterIn/onEnterFrame()

Note: To test this game on desktop you'll need to merge in #11159 because I broke left/right arrow key controls on desktop with my text control PR (sorry!)

[KrzysztofoGuard]

Tell me, will the "Super goblin war machine" game I submitted for revival to the Ruffle team will work, or have you already become discouraged? I realize there have been any problems recently, so please give me a specific answer.

[n0samu]

@KrzysztofoGuard The answer to your question is here #11051 (comment). There some more things we need to figure out before the game will work at all.

[n0samu]

I can confirm that with #11195 also merged in, Pursuit of Hat no longer regresses!

[waspennator]

Should close #8409 with pony towers being unable to damage targets.

[SN902]

Found regression V8MuscleCars.zip after intro this game stuck on black screen with ERROR ruffle_core::avm2::events: Error dispatching event EventObject(EventObject { type: "enterFrame", class: flash.events::Event, ptr: 0x2a000207ba8 }) to handler FunctionObject(FunctionObject { ptr: 0x2a07acda048 }) : TypeError: Error 1009: Cannot access a property or method of a null object reference. (accessing field: numChildren)

[Aaron1011]

@SN902 I pushed a new commit which should fix the regression

[SN902]

@SN902 I pushed a new commit which should fix the regression

Fixed