Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Gitea Config #416

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Gitea Config #416

wants to merge 1 commit into from

Conversation

julienym
Copy link

what

Gitea support for the chart
PR open to seak comments, need more works

why

tests

references

julienym
julienym commented Aug 28, 2024
View reviewed changes
charts/atlantis/templates/statefulset.yaml
secretKeyRef:
name: {{ template "atlantis.vcsSecretName" . }}
key: gitea_token
{{- if .Values.gitea.baseURL }}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we aim for gitea.com if not provided?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say, let's use the same logic as the others and leave it empty when not provided:

@bachorp bachorp mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMartinez-Sisti GMartinez-Sisti GMartinez-Sisti left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienym @GMartinez-Sisti