Update to bitcoin 0.28.0 release#337
Closed
dr-orlovsky wants to merge 4 commits intorust-bitcoin:masterfrom
BP-WG:canary
Closed
Update to bitcoin 0.28.0 release#337dr-orlovsky wants to merge 4 commits intorust-bitcoin:masterfrom BP-WG:canary
dr-orlovsky wants to merge 4 commits intorust-bitcoin:masterfrom
BP-WG:canary
Conversation
Reproducible with automatic case-sensetive search/replace
sanket1729
reviewed
Apr 5, 2022
Member
sanket1729
left a comment
sanket1729
left a comment
There was a problem hiding this comment.
I would like these to be squashed eventually.
If possible, you can add atomic patches here. But later open another PR with a single commit.
| pub fn is_valid(&self) -> Result<(), PolicyError> { | ||
| self.check_timelocks()?; | ||
| self.check_duplicate_keys()?; | ||
| // self.check_duplicate_keys()?; |
Contributor
Merged
Contributor
Author
|
Closing due to #359 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #336.
Will be un-drafted once the release is published.
@sanket1729 pls let me know will I need to squash the commits on update (they do not compile one-by-one, and I made them to simplify the review).