Conversation
Contributor
|
I was going to update my original PR #337, but since you already made this, let's go with this. |
144f1de to
859d428
Compare
Rename SigHash* into Sighash accross the repo Reproducible with automatic case-sensetive search/replace Make taproot leaf script depth to be u8 everywhere co-authored-by: sanket1729 <sanket1729@gmail.com>
859d428 to
271191b
Compare
apoelstra
approved these changes
Apr 20, 2022
Member
apoelstra
left a comment
There was a problem hiding this comment.
ACK 271191b
@sanket1729 this is good to merge/release?
Member
Author
|
@apoelstra , yes! |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
271191b130efc38ca9da51d1f44a796bf3a95dab Release 7.0.0 (Dr Maxim Orlovsky)
Pull request description:
Rename SigHash* into Sighash accross the repo
Reproducible with automatic case-sensetive search/replace
Make taproot leaf script depth to be u8 everywhere
I have changed the release notes title from 7.0.0-rc.2 to 7.0.0.
ACKs for top commit:
apoelstra:
ACK 271191b130efc38ca9da51d1f44a796bf3a95dab
Tree-SHA512: c77bddaef4ac0862be9920c1d65a6abf2e67226b3b18ce9f873ddfa33d2889427fb05f29cf31174b00fe2849ee84ddb006f8e8632b3ba4497abaf42e66d1fe75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename SigHash* into Sighash accross the repo
Reproducible with automatic case-sensetive search/replace
Make taproot leaf script depth to be u8 everywhere
I have changed the release notes title from 7.0.0-rc.2 to 7.0.0.