String: add StringView, similar to VecView
#452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use a macro to implement the traits, as I did in #451. |
|
Done. And I added some inline hints similarly to #451 |
sosthene-nitrokey
force-pushed
the
string-view
branch
2 times, most recently
from
ceafc9e
to
a0145fe
Compare
sosthene-nitrokey
force-pushed
the
string-view
branch
2 times, most recently
from
2ef7655
to
db03247
Compare
sosthene-nitrokey
force-pushed
the
string-view
branch
from
db03247
to
7c2692c
Compare
sosthene-nitrokey
force-pushed
the
string-view
branch
from
7c2692c
to
6f4bc06
Compare
sosthene-nitrokey
force-pushed
the
string-view
branch
from
6f4bc06
to
ce2d1c3
Compare
|
closing in favor of #487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #425
This time we need a dedicated
sealedmodule forStringInner, because of thepub mod stringinlib.rs. MaybeVecInnershould have the same treatment, in case some time in the future thevecmodule is made public.