Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String: implement StringView on top of #486 #487

Merged
merged 4 commits into from
Jul 1, 2024
Merged

String: implement StringView on top of #486 #487

merged 4 commits into from
Jul 1, 2024

Conversation

sosthene-nitrokey
Copy link
Contributor

@sosthene-nitrokey sosthene-nitrokey commented Jun 28, 2024 •
edited

If #486 is merged, this would supersede #452

@Dirbaio
Copy link
Member

Dirbaio commented Jun 30, 2024

can you generalize the defmt, ufmt impls too?

@Dirbaio Dirbaio mentioned this pull request Jun 30, 2024
Closed
@sosthene-nitrokey
Copy link
Contributor Author

Done

@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Jul 1, 2024
Open
Dirbaio
Dirbaio approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Dirbaio Dirbaio added this pull request to the merge queue Jul 1, 2024
Merged via the queue into rust-embedded:main with commit e43a751 Jul 1, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sosthene-nitrokey @Dirbaio