New lint [tuple_array_conversions]

[Centri3]

Closes #10748

PS, the implementation is a bit ugly 😅 I will likely refactor soon enough :) Done :D

changelog: New lint [tuple_array_conversions]

[rustbot]

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

[llogiq]

Looks good to me. Thank you!

Could we determine whether type annotations are needed and otherwise shorten the help text? In any event, that could be a follow-up PR.

@bors r+

[bors]

📌 Commit 1090bf3 has been approved by llogiq

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1090bf3 with merge d864b13...

[bors]

💔 Test failed - checks-action_test

[bors]

☔ The latest upstream changes (presumably #10884) made this pull request unmergeable. Please resolve the merge conflicts.

[Centri3]

@llogiq, CI unfortunately failed because of collect-metadata. It should pass now.

[bors]

☔ The latest upstream changes (presumably #11030) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

📌 Commit eeb3d96 has been approved by llogiq

It is now in the queue for this repository.

[bors]

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

1. git checkout tuple_array_conversion (switch to your branch)
2. git fetch upstream master (retrieve the latest master)
3. git rebase upstream/master -p (rebase on top of it)
4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
5. git push self tuple_array_conversion --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging clippy_utils/src/msrvs.rs
CONFLICT (content): Merge conflict in clippy_utils/src/msrvs.rs
Auto-merging clippy_lints/src/utils/conf.rs
CONFLICT (content): Merge conflict in clippy_lints/src/utils/conf.rs
Auto-merging book/src/lint_configuration.md
Automatic merge failed; fix conflicts and then commit the result.

[llogiq]

@bors r-

Please rebase.

[Centri3]

Was just about to :D

[llogiq]

@bors r+

[bors]

📌 Commit 826edd7 has been approved by llogiq

It is now in the queue for this repository.

[bors]

⌛ Testing commit 826edd7 with merge c7bf05c...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing c7bf05c to master...

[kupiakos]

Given the line let (a, b) = (buf[0], buf[1]);, I would not replace it with let (a, b) = buf.into(); as this lints suggests, but instead write let [a, b] = buf;. The goal is not to convert to a tuple, it's to get multiple bindings.