opt-dist: change build_dir field to be an actual build dir by ognevny · Pull Request #144159 · rust-lang/rust

ognevny · 2025-07-18T21:03:14Z

make it configurable so users can set build.build-dir option in bootstrap.toml

r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux

rustbot · 2025-07-18T21:05:08Z

Some changes occurred in src/tools/opt-dist

cc @Kobzol

ognevny · 2025-07-19T08:37:24Z

ready

src/tools/opt-dist/src/main.rs

Kobzol · 2025-07-20T11:42:52Z

@bors2 try @rust-timer queue

opt-dist: change build_dir field to be an actual build dir make it configurable so users can set build.build-dir option in bootstrap.toml    r? Kobzol try-job: dist-x86_64-msvc try-job: dist-x86_64-linux

rust-bors · 2025-07-20T11:42:56Z

⌛ Trying commit 2243454 with merge 6435e25…

To cancel the try build, run the command @bors2 try cancel.

rust-bors · 2025-07-20T14:42:17Z

☀️ Try build successful (CI)
Build commit: 6435e25 (6435e254d9df85830b49c76f6c4df910d623c77f, parent: 81af9d45698a19183b8552079cbc7bf893fad1e5)

rust-timer · 2025-07-20T16:36:28Z

Finished benchmarking commit (6435e25): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%, secondary 4.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[4.6%, 4.6%]	1
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Cycles

Results (primary -2.2%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.3s -> 465.671s (0.08%)
Artifact size: 374.58 MiB -> 374.56 MiB (-0.00%)

make it configurable so users can set build.build-dir option in bootstrap.toml

Kobzol · 2025-07-20T19:10:46Z

@bors r+ rollup

bors · 2025-07-20T19:10:49Z

📌 Commit 6fd83ea has been approved by Kobzol

It is now in the queue for this repository.

opt-dist: change build_dir field to be an actual build dir make it configurable so users can set build.build-dir option in bootstrap.toml r? Kobzol try-job: dist-x86_64-msvc try-job: dist-x86_64-linux

Rollup of 7 pull requests Successful merges: - #142097 (gpu offload host code generation) - #143906 (Miri: non-deterministic floating point operations in `foreign_items`) - #144144 (tests: Skip supported-crate-types test on musl hosts) - #144159 (opt-dist: change build_dir field to be an actual build dir) - #144162 (Debug impls for DropElaborators) - #144189 (Add non-regression test for #144168) - #144216 (Don't consider unstable fields always-inhabited) r? `@ghost` `@rustbot` modify labels: rollup

GuillaumeGomez · 2025-07-20T21:28:05Z

I suspect it's the one which failed in #144228.

ognevny · 2025-07-20T21:30:24Z

but how? I did change for a tool which is used for some dist jobs only

GuillaumeGomez · 2025-07-20T21:34:17Z

It's just a suspicion. I don't see which PR of the rollup could have trigger the issue (if it's not just a flaky issue). So for now it's out of the rollup but still approved and will get merged.

Kobzol · 2025-07-20T22:00:15Z

It most likely wasn't this PR, it's a spurious issue.

GuillaumeGomez · 2025-07-20T22:02:31Z

That confirms my suspicion of flakyness then. :)

Rollup of 8 pull requests Successful merges: - #144144 (tests: Skip supported-crate-types test on musl hosts) - #144159 (opt-dist: change build_dir field to be an actual build dir) - #144162 (Debug impls for DropElaborators) - #144189 (Add non-regression test for #144168) - #144216 (Don't consider unstable fields always-inhabited) - #144229 (Miri subtree update) - #144230 (Option::as_slice: fix comment) - #144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup

opt-dist: change build_dir field to be an actual build dir make it configurable so users can set build.build-dir option in bootstrap.toml r? Kobzol try-job: dist-x86_64-msvc try-job: dist-x86_64-linux

Rollup of 8 pull requests Successful merges: - #144144 (tests: Skip supported-crate-types test on musl hosts) - #144159 (opt-dist: change build_dir field to be an actual build dir) - #144162 (Debug impls for DropElaborators) - #144189 (Add non-regression test for #144168) - #144216 (Don't consider unstable fields always-inhabited) - #144229 (Miri subtree update) - #144230 (Option::as_slice: fix comment) - #144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144159 - ognevny:opt-dist-build-dir, r=Kobzol opt-dist: change build_dir field to be an actual build dir make it configurable so users can set build.build-dir option in bootstrap.toml r? Kobzol try-job: dist-x86_64-msvc try-job: dist-x86_64-linux

opt-dist: change build_dir field to be an actual build dir make it configurable so users can set build.build-dir option in bootstrap.toml r? Kobzol try-job: dist-x86_64-msvc try-job: dist-x86_64-linux

Rollup of 8 pull requests Successful merges: - rust-lang#144144 (tests: Skip supported-crate-types test on musl hosts) - rust-lang#144159 (opt-dist: change build_dir field to be an actual build dir) - rust-lang#144162 (Debug impls for DropElaborators) - rust-lang#144189 (Add non-regression test for rust-lang#144168) - rust-lang#144216 (Don't consider unstable fields always-inhabited) - rust-lang#144229 (Miri subtree update) - rust-lang#144230 (Option::as_slice: fix comment) - rust-lang#144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - rust-lang/rust#144144 (tests: Skip supported-crate-types test on musl hosts) - rust-lang/rust#144159 (opt-dist: change build_dir field to be an actual build dir) - rust-lang/rust#144162 (Debug impls for DropElaborators) - rust-lang/rust#144189 (Add non-regression test for rust-lang/rust#144168) - rust-lang/rust#144216 (Don't consider unstable fields always-inhabited) - rust-lang/rust#144229 (Miri subtree update) - rust-lang/rust#144230 (Option::as_slice: fix comment) - rust-lang/rust#144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Kobzol Jul 18, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 18, 2025

ognevny marked this pull request as ready for review July 18, 2025 21:05

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2025

ognevny mentioned this pull request Jul 19, 2025

opt-dist: add an option for setting path to stage0 root #144164

Merged

ognevny force-pushed the opt-dist-build-dir branch from ca191d4 to 2243454 Compare July 19, 2025 08:36

This comment has been minimized.

Sign in to view

Kobzol reviewed Jul 20, 2025

View reviewed changes

src/tools/opt-dist/src/main.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2025

opt-dist: change build_dir field to be an actual build dir

6fd83ea

make it configurable so users can set build.build-dir option in bootstrap.toml

ognevny force-pushed the opt-dist-build-dir branch from 2243454 to 6fd83ea Compare July 20, 2025 17:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2025

GuillaumeGomez mentioned this pull request Jul 20, 2025

Rollup of 7 pull requests #144228

Closed

jhpratt mentioned this pull request Jul 21, 2025

Rollup of 8 pull requests #144238

Merged

jieyouxu mentioned this pull request Jul 21, 2025

Rollup of 10 pull requests #144245

Closed

bors merged commit a275a5f into rust-lang:master Jul 21, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 21, 2025

ognevny deleted the opt-dist-build-dir branch July 21, 2025 11:48

Uh oh!

Conversation

ognevny commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 18, 2025

Uh oh!

ognevny commented Jul 19, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Kobzol commented Jul 20, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jul 20, 2025

Uh oh!

rust-bors bot commented Jul 20, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 20, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Jul 20, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

GuillaumeGomez commented Jul 20, 2025

Uh oh!

ognevny commented Jul 20, 2025

Uh oh!

GuillaumeGomez commented Jul 20, 2025

Uh oh!

Kobzol commented Jul 20, 2025

Uh oh!

GuillaumeGomez commented Jul 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ognevny commented Jul 18, 2025 •

edited

Loading