Port `#[must_not_suspend]` to attribute parser #150943

Bryntet · 2026-01-10T23:43:12Z

Tracking issue: #131229

r? @JonathanBrouwer

rustbot · 2026-01-10T23:43:15Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

jdonszelmann · 2026-01-11T08:16:11Z

@bors r+ rollup

rust-bors · 2026-01-11T08:16:15Z

📌 Commit 7c54db8 has been approved by jdonszelmann

It is now in the queue for this repository.

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) - #150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - #150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

rust-bors · 2026-01-11T15:36:21Z

☔ The latest upstream changes (presumably #150957) made this pull request unmergeable. Please resolve the merge conflicts.

This pull request was unapproved.

@ghost

Rollup of 14 pull requests Successful merges: - rust-lang/rust#148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - rust-lang/rust#150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - rust-lang/rust#150668 (Unix implementation for stdio set/take/replace) - rust-lang/rust#150743 (Reword the collect() docs) - rust-lang/rust#150776 (Fix the connect_error test on FreeBSD 15+) - rust-lang/rust#150781 (Use `rand` crate more idiomatically) - rust-lang/rust#150812 (Bump `diesel` to the most recent commit in `cargotest`) - rust-lang/rust#150862 (std: sys: fs: uefi: Implement File::flush) - rust-lang/rust#150873 (Reenable GCC CI download) - rust-lang/rust#150908 (llvm: Update `reliable_f16` configuration for LLVM22) - rust-lang/rust#150918 (std: sys: fs: uefi: Implement File::seek) - rust-lang/rust#150922 (Subscribe myself to attr parsing) - rust-lang/rust#150930 (Remove special case for `AllowedTargets::CrateLevel`) - rust-lang/rust#150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - rust-lang/rust#150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

rustbot · 2026-01-12T17:20:00Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-01-12T17:32:55Z

@bors r=jdonszelmann,JonathanBrouwer

rust-bors · 2026-01-12T17:33:00Z

📌 Commit 418cff3 has been approved by jdonszelmann,JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…ann,JonathanBrouwer Port `#[must_not_suspend]` to attribute parser Tracking issue: rust-lang#131229 r? @JonathanBrouwer

@ghost

…uwer Rollup of 13 pull requests Successful merges: - #145343 (Dogfood `-Zno-embed-metadata` in the standard library) - #150151 (Destabilise `target-spec-json`) - #150723 (std: move `errno` and related functions into `sys::io`) - #150771 (Remove legacy homu `try` and `auto` branch mentions) - #150826 (Add `f16` inline ASM support for s390x) - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`) - #150943 (Port `#[must_not_suspend]` to attribute parser) - #150990 (std: sys: net: uefi: Make TcpStream Send) - #150995 (core: ptr: split_at_mut: fix typo in safety doc) - #150998 (Relax test expectation for @__llvm_profile_runtime_user) - #151002 (Remove a workaround for a bug (take 2)) - #151005 (Fix typo in `MaybeUninit` docs) - #151011 (Update books) r? @ghost

@JonathanBrouwer

…ann,JonathanBrouwer Port `#[must_not_suspend]` to attribute parser Tracking issue: rust-lang#131229 r? @JonathanBrouwer

@ghost

Rollup of 12 pull requests Successful merges: - #145343 (Dogfood `-Zno-embed-metadata` in the standard library) - #150151 (Destabilise `target-spec-json`) - #150723 (std: move `errno` and related functions into `sys::io`) - #150826 (Add `f16` inline ASM support for s390x) - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`) - #150943 (Port `#[must_not_suspend]` to attribute parser) - #150990 (std: sys: net: uefi: Make TcpStream Send) - #150995 (core: ptr: split_at_mut: fix typo in safety doc) - #150998 (Relax test expectation for @__llvm_profile_runtime_user) - #151002 (Remove a workaround for a bug (take 2)) - #151005 (Fix typo in `MaybeUninit` docs) - #151011 (Update books) r? @ghost

@ghost

…uwer Rollup of 14 pull requests Successful merges: - #150151 (Destabilise `target-spec-json`) - #150826 (Add `f16` inline ASM support for s390x) - #150883 (Improve span for "unresolved intra doc link" on `deprecated` attribute) - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`) - #150943 (Port `#[must_not_suspend]` to attribute parser) - #150990 (std: sys: net: uefi: Make TcpStream Send) - #150995 (core: ptr: split_at_mut: fix typo in safety doc) - #150998 (Relax test expectation for @__llvm_profile_runtime_user) - #151002 (Remove a workaround for a bug (take 2)) - #151005 (Fix typo in `MaybeUninit` docs) - #151011 (Update books) - #151029 (rustc-dev-guide subtree update) - #151032 (fix: added missing backtick in triagebot.toml) - #151035 (Don't suggest replacing closure parameter with type name) r? @ghost

@JonathanBrouwer

Rollup merge of #150943 - port_must_not_suspend, r=jdonszelmann,JonathanBrouwer Port `#[must_not_suspend]` to attribute parser Tracking issue: #131229 r? @JonathanBrouwer

JonathanBrouwer · 2026-01-13T16:04:22Z

@rust-timer build 3344a15
Looking into perf regression of #151051

JonathanBrouwer · 2026-01-13T17:57:07Z

@rust-timer build 3344a15

rust-timer · 2026-01-13T19:39:56Z

Finished benchmarking commit (3344a15): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.4%, -0.1%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	[1.1%, 1.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.6%, -2.0%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.6%, secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.5%, 2.8%]	2
Regressions ❌ (secondary)	2.8%	[2.7%, 2.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[2.5%, 2.8%]	2

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	43
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	23
All ❌✅ (primary)	-0.1%	[-0.1%, -0.0%]	43

Bootstrap: 473.958s -> 475.813s (0.39%)
Artifact size: 383.19 MiB -> 383.13 MiB (-0.01%)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 10, 2026

rustbot assigned JonathanBrouwer Jan 10, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2026

jdonszelmann mentioned this pull request Jan 11, 2026

Tracking issue: Attribute refactor #131229

Open

9 tasks

matthiaskrgr mentioned this pull request Jan 11, 2026

Rollup of 14 pull requests #150957

Merged

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 11, 2026

rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 11, 2026

Port #[must_not_suspend] to attribute parser

418cff3

Bryntet force-pushed the port_must_not_suspend branch from 7c54db8 to 418cff3 Compare January 12, 2026 17:19

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2026

JonathanBrouwer mentioned this pull request Jan 12, 2026

Rollup of 13 pull requests #151023

Closed

matthiaskrgr mentioned this pull request Jan 12, 2026

Rollup of 12 pull requests #151038

Closed

JonathanBrouwer mentioned this pull request Jan 13, 2026

Rollup of 14 pull requests #151051

Merged

rust-bors bot merged commit a299406 into rust-lang:main Jan 13, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 13, 2026

rust-timer added a commit that referenced this pull request Jan 13, 2026

Unrolled build for #150943

3344a15

Rollup merge of #150943 - port_must_not_suspend, r=jdonszelmann,JonathanBrouwer Port `#[must_not_suspend]` to attribute parser Tracking issue: #131229 r? @JonathanBrouwer

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

Uh oh!

Port #[must_not_suspend] to attribute parser #150943

Port #[must_not_suspend] to attribute parser #150943

Uh oh!

Conversation

Bryntet commented Jan 10, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 10, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

rust-bors bot commented Jan 11, 2026

Uh oh!

rust-bors bot commented Jan 11, 2026

Uh oh!

rustbot commented Jan 12, 2026

Uh oh!

JonathanBrouwer commented Jan 12, 2026

Uh oh!

rust-bors bot commented Jan 12, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Jan 13, 2026

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

JonathanBrouwer commented Jan 13, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jan 13, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Port `#[must_not_suspend]` to attribute parser #150943

Port `#[must_not_suspend]` to attribute parser #150943

Bryntet commented Jan 10, 2026 •

edited by rustbot

Loading