-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Rollup of 14 pull requests #151051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #151051
Conversation
Added an example for profiling an external crate diff locally. The original issue also mentions that the debuginfo-level = 1 should be highlighted, but that has been solved by a different commit and as such was not included here.
Changed so cargo specifies the binary collector, removing the need to link to its local binary. Clarified that the SHAs should be from the rustc-repo, but the command should be ran in the rustc-perf repo.
Fix rust-lang#1692: Add example for profiling diff locally
docs:improve const generics
Co-authored-by: Deadbeef <[email protected]>
Retire outdated stage0 std remarks
This updates the rust-version file to 44a5b55.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@44a5b55 Filtered ref: rust-lang/rustc-dev-guide@df5b7c4 Upstream diff: rust-lang/rust@85c8ff6...44a5b55 This merge was created using https://github.com/rust-lang/josh-sync.
Removes the double subject "it" in the safety documentation of `core::ptr::split_at_mut` for raw slice pointers, as it does not refer to anything. Reported-by: Johnathan Van Why <[email protected]>
Rustc pull update
After llvm/llvm-project#174174 it has profile info marking it cold.
Fix indent in rust code
I don't think it is necessary anymore. As I understand it from issue 39504 the original problem was that rustbuild changed a hardlink in the cargo build dir to point to copy in the sysroot while cargo may have hardlinked it to the original first. I don't think this happens anymore and as such this workaround is no longer necessary.
–- → – (extra ASCII minus after endash) Introduced in rust-lang#140463 (11627f0).
- Since UEFI has no threads, this should be safe. - Makes compiling remote-test-server simpler. Signed-off-by: Ayush Singh <[email protected]>
sembt borrow_check/opaque-types-region-inference-restrictions
|
@bors r+ rollup=never p=5 |
|
@bors try jobs=dist-various-*,test-various |
This comment has been minimized.
This comment has been minimized.
Rollup of 14 pull requests try-job: dist-various-* try-job: test-various
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing b2a322b (parent) -> db1484b (this PR) Test differencesShow 634 test diffsStage 0
Stage 1
(and 522 additional test diffs) Additionally, 12 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard db1484bdee1cb065b322a5bd512b39c49dadc9e5 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: b2a322beb2 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (db1484b): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.3%, secondary -2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResults (primary 0.2%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 473.958s -> 474.378s (0.09%) |
|
Probably an attr related regression again :c |
Successful merges:
target-spec-json#150151 (Destabilisetarget-spec-json)f16inline ASM support for s390x #150826 (Addf16inline ASM support for s390x)deprecatedattribute #150883 (Improve span for "unresolved intra doc link" ondeprecatedattribute)check_doc_attrsdirectly intorustc_attr_parsing#150934 (Move some checks fromcheck_doc_attrsdirectly intorustc_attr_parsing)#[must_not_suspend]to attribute parser #150943 (Port#[must_not_suspend]to attribute parser)MaybeUninitdocs #151005 (Fix typo inMaybeUninitdocs)r? @ghost
Create a similar rollup