Skip to content

Rename EII attributes slightly (being consistent in naming things foreign items, not extern items) #150972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 2 commits into from
Jan 12, 2026
Merged

Rename EII attributes slightly (being consistent in naming things foreign items, not extern items) #150972

rust-bors merged 2 commits into from
Jan 12, 2026
+137 −138

Conversation

@jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Jan 11, 2026

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 11, 2026
Kivooeo
Kivooeo approved these changes Jan 11, 2026
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple renaming, so looks good

r=me once ci green

View changes since this review

@Kivooeo Kivooeo mentioned this pull request Jan 11, 2026
Merged
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Jan 11, 2026

@bors r=kivooeo

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

📌 Commit fdd5e04 has been approved by kivooeo

It is now in the queue for this repository.

@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Jan 11, 2026

@bors rollup

@jdonszelmann jdonszelmann mentioned this pull request Jan 11, 2026
Closed
rust-bors bot added a commit that referenced this pull request Jan 11, 2026
@rust-bors
Auto merge of #150974 - jdonszelmann:rollup-R4vhnZ0, r=jdonszelmann
7ce2e85 
Rollup of 7 pull requests

Successful merges:

 - #147938 (Add const cloning of slices and tests)
 - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150906 (Simplify `#[eii]` macro using methods on ecx)
 - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
 - #150953 (std: sys: fs: uefi: Implement copy)
 - #150964 (Completely list all unparsed attributes)

Failed merges:

 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))

r? @ghost
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 11, 2026
Closed
rust-bors bot added a commit that referenced this pull request Jan 11, 2026
@rust-bors
Auto merge of #150978 - matthiaskrgr:rollup-4WgAvF9, r=matthiaskrgr
aa9292d 
Rollup of 7 pull requests

Successful merges:

 - #147938 (Add const cloning of slices and tests)
 - #149718 (Add freeze file times on Windows)
 - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
 - #150906 (Simplify `#[eii]` macro using methods on ecx)
 - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
 - #150953 (std: sys: fs: uefi: Implement copy)
 - #150964 (Completely list all unparsed attributes)

Failed merges:

 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))

r? @ghost
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 11, 2026
Merged
rust-bors bot added a commit that referenced this pull request Jan 12, 2026
@rust-bors
Auto merge of #150981 - matthiaskrgr:rollup-px5fFnj, r=matthiaskrgr
840245e 
Rollup of 9 pull requests

Successful merges:

 - #147938 (Add const cloning of slices and tests)
 - #149718 (Add freeze file times on Windows)
 - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
 - #150790 (feat: invisible character help string)
 - #150906 (Simplify `#[eii]` macro using methods on ecx)
 - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
 - #150953 (std: sys: fs: uefi: Implement copy)
 - #150964 (Completely list all unparsed attributes)
 - #150975 (ui: add test for normalizing const projections with assoc const equality)

Failed merges:

 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))

r? @ghost
@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 12, 2026

☔ The latest upstream changes (presumably #150981) made this pull request unmergeable. Please resolve the merge conflicts.

This pull request was unapproved.

@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Jan 12, 2026

@bors r+

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 12, 2026

📌 Commit 6d0f23a has been approved by jdonszelmann

It is now in the queue for this repository.

@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Jan 12, 2026

@bors r-

@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 12, 2026

Commit 6d0f23a has been unapproved.

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 12, 2026
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Jan 12, 2026

@bors r=kivooeo

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 12, 2026

📌 Commit 6d0f23a has been approved by kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 12, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 12, 2026
@matthiaskrgr
Rollup merge of rust-lang#150972 - rename-attrs, r=kivooeo
4d9460b 
Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)

r? @Kivooeo
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 12, 2026
Closed
rust-bors bot added a commit that referenced this pull request Jan 12, 2026
@rust-bors
Auto merge of #150994 - matthiaskrgr:rollup-V3hCGEm, r=matthiaskrgr
5c0c901 
Rollup of 5 pull requests

Successful merges:

 - #150861 (Folding/`ReErased` cleanups)
 - #150941 (rustc_parse_format: improve diagnostics for unsupported python numeric grouping)
 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))
 - #150980 (Use updated indexes to build reverse map for delegation generics)
 - #150986 (std: Fix size returned by UEFI tcp4 read operations)

r? @ghost
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 12, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 12, 2026
@bors
Auto merge of #151003 - matthiaskrgr:rollup-wvnF9sN, r=matthiaskrgr
b53b0fa 
Rollup of 8 pull requests

Successful merges:

 - #150861 (Folding/`ReErased` cleanups)
 - #150869 (Emit error instead of delayed bug when meeting mismatch type for const tuple)
 - #150920 (Use a hook to decouple `rustc_mir_transform` from `rustc_mir_build`)
 - #150941 (rustc_parse_format: improve diagnostics for unsupported python numeric grouping)
 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))
 - #150980 (Use updated indexes to build reverse map for delegation generics)
 - #150986 (std: Fix size returned by UEFI tcp4 read operations)
 - #150996 (Remove `S-waiting-on-bors` after a PR is merged)

r? @ghost
rust-bors bot pushed a commit that referenced this pull request Jan 12, 2026
@bors
Auto merge of #151003 - matthiaskrgr:rollup-wvnF9sN, r=matthiaskrgr
aefa104 
Rollup of 8 pull requests

Successful merges:

 - #150861 (Folding/`ReErased` cleanups)
 - #150869 (Emit error instead of delayed bug when meeting mismatch type for const tuple)
 - #150920 (Use a hook to decouple `rustc_mir_transform` from `rustc_mir_build`)
 - #150941 (rustc_parse_format: improve diagnostics for unsupported python numeric grouping)
 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))
 - #150980 (Use updated indexes to build reverse map for delegation generics)
 - #150986 (std: Fix size returned by UEFI tcp4 read operations)
 - #150996 (Remove `S-waiting-on-bors` after a PR is merged)

r? @ghost
@rust-bors rust-bors bot merged commit 681058e into rust-lang:main Jan 12, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 12, 2026
rust-timer added a commit that referenced this pull request Jan 12, 2026
@rust-timer
Unrolled build for #150972
cbeed52 
Rollup merge of #150972 - rename-attrs, r=kivooeo

Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)

r? @Kivooeo
@jdonszelmann jdonszelmann mentioned this pull request Jan 14, 2026
Open
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@Kivooeo Kivooeo

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jdonszelmann @rustbot @Kivooeo