Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jan 13, 2026

Successful merges:

r? @ghost

Create a similar rollup

AaryanAgrawal96 and others added 30 commits January 2, 2026 14:09
When a trait parameter depends upon Sized, the error message only
referred to the full trait itself and didn't mention Sized. This makes
the failure to implement Sized explicit. It also notes when the Sized
trait bound is explicit or implicit.
I chose to simply extend `dump.rs`, rather than create a new UI test.
Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs

Fix to comply with tidy

Remove unnecessary whitespace
With the suggested value we were getting instead:

```
ERROR: Failed to parse '/tmp/rust/bootstrap.toml': unknown field `stage`, expected one of `build`, `description`, `host`, `target`, `build-dir`, `cargo`, `rustc`, `rustfmt`, `cargo-clippy`, `docs`, `compiler-docs`, `library-docs-private-items`, `docs-minification`, `submodules`, `gdb`, `lldb`, `nodejs`, `npm`, `yarn`, `python`, `windows-rc`, `reuse`, `locked-deps`, `vendor`, `full-bootstrap`, `bootstrap-cache-path`, `extended`, `tools`, `tool`, `verbose`, `sanitizers`, `profiler`, `cargo-native-static`, `low-priority`, `configure-args`, `local-rebuild`, `print-step-timings`, `print-step-rusage`, `check-stage`, `doc-stage`, `build-stage`, `test-stage`, `install-stage`, `dist-stage`, `bench-stage`, `patch-binaries-for-nix`, `metrics`, `android-ndk`, `optimized-compiler-builtins`, `jobs`, `compiletest-diff-tool`, `compiletest-allow-stage0`, `compiletest-use-stage0-libtest`, `tidy-extra-checks`, `ccache`, `exclude` for key `build`
```
The old toolchain is not working with recent rustc, as it does not
defining `getauxval`
triagebot: add A-rustdoc-js autolabel

Adds an autolabel rule for rustdoc JavaScript/TypeScript files so PRs touching
rustdoc frontend assets and related tests are automatically labeled `A-rustdoc-js`.

Fixes rust-lang#137983
Improve std::path::Path::join documentation

Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs

rust-lang#146447
diagnostics: make implicit Sized bounds explicit in E0277

When a trait parameter depends upon Sized, the error message only referred to the full trait itself and didn't mention Sized. This makes the failure to implement Sized explicit. It also notes when the Sized trait bound is explicit or implicit.

Fixes rust-lang#150576
Remove legacy homu `try` and `auto` branch mentions

~~To be merged once we get rid of homu.~~ I think that we can merge this now.
…nethercote

Make `--print=check-cfg` output compatible `--check-cfg` arguments

This PR changes significantly the output of the unstable `--print=check-cfg` option.

Specifically it removes the ad-hoc resemblance with `--print=cfg` in order to output a simplified but still compatible `--check-cfg` arguments.

The goal is to future proof the output of `--print=check-cfg` like `--check-cfg` is, and the best way to do that is to use it's syntax.

This is particularly relevant for [RFC3905](rust-lang/rfcs#3905) which wants to introduce a new predicate: `version(...)`.
@rustbot rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jan 13, 2026
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=5 rollup=never

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 13, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

📌 Commit 3adbd3a has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2026
@GuillaumeGomez GuillaumeGomez deleted the rollup-vIdiReJ branch January 13, 2026 23:28
@GuillaumeGomez GuillaumeGomez restored the rollup-vIdiReJ branch January 13, 2026 23:29
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2026
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=5 rollup=never

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

📌 Commit 3adbd3a has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Jan 14, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 14, 2026

☀️ Test successful - CI
Approved by: GuillaumeGomez
Pushing 4931e09 to main...

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2026
@rust-bors rust-bors bot merged commit 4931e09 into rust-lang:main Jan 14, 2026
14 of 23 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 14, 2026
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing fcac501 (parent) -> 4931e09 (this PR)

Test differences

Show 114 test diffs

Stage 1

  • [ui] tests/ui/const-generics/mgca/array-expr-type-mismatch-in-where-bound.rs: [missing] -> pass (J0)
  • [ui] tests/ui/eii/type_checking/generic_implementation.rs: [missing] -> pass (J0)
  • [ui] tests/ui/eii/type_checking/type_params_149983.rs: [missing] -> pass (J0)
  • [ui] tests/ui/error-codes/E0277-4.rs: [missing] -> pass (J0)
  • [ui] tests/ui/reflection/tuples.rs: pass -> [missing] (J0)
  • [ui] tests/ui/resolve/decl-macro-use-no-ice.rs: [missing] -> pass (J0)
  • mem::type_info::test_arrays: [missing] -> pass (J1)
  • mem::type_info::test_tuples: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/const-generics/mgca/array-expr-type-mismatch-in-where-bound.rs: [missing] -> pass (J2)
  • [ui] tests/ui/eii/type_checking/generic_implementation.rs: [missing] -> pass (J2)
  • [ui] tests/ui/eii/type_checking/type_params_149983.rs: [missing] -> pass (J2)
  • [ui] tests/ui/error-codes/E0277-4.rs: [missing] -> pass (J2)
  • [ui] tests/ui/reflection/tuples.rs: pass -> [missing] (J2)
  • [ui] tests/ui/resolve/decl-macro-use-no-ice.rs: [missing] -> pass (J2)
  • mem::type_info::test_arrays: [missing] -> pass (J3)
  • mem::type_info::test_tuples: [missing] -> pass (J3)

Additionally, 98 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4931e09e3ac3182d2a00f38cccfdf68e8e385e1c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1637.2s -> 2058.5s (+25.7%)
  2. dist-x86_64-apple: 7358.3s -> 8938.9s (+21.5%)
  3. aarch64-gnu-llvm-20-2: 2994.6s -> 3351.3s (+11.9%)
  4. i686-gnu-2: 5340.8s -> 5918.3s (+10.8%)
  5. dist-arm-linux-musl: 5483.2s -> 6067.9s (+10.7%)
  6. dist-aarch64-llvm-mingw: 5999.8s -> 5401.1s (-10.0%)
  7. x86_64-gnu-llvm-20-2: 5347.8s -> 5864.8s (+9.7%)
  8. dist-ohos-armv7: 3801.6s -> 4164.9s (+9.6%)
  9. x86_64-gnu-tools: 3408.1s -> 3733.4s (+9.5%)
  10. dist-aarch64-linux: 6010.1s -> 6572.6s (+9.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150587 triagebot: add A-rustdoc-js autolabel 41c8566e9829584a351c218e87d9735b17bfcfdb (link)
#150677 Improve std::path::Path::join documentation 8e9884c481d5d33be065d4bb4849fdf86d1e0610 (link)
#150737 diagnostics: make implicit Sized bounds explicit in E0277 6d062e5f29bbc917e6c59d374a95d9655c717149 (link)
#150771 Remove legacy homu try and auto branch mentions e67436849ccc45800b8b4a25ec2b256aba13bf90 (link)
#150840 Make --print=check-cfg output compatible --check-cfg ar… cc3903c92c863419caf68d2d95b7c266aa41303d (link)
#150915 Regression test for type params on eii 7b02f30597ca23f481441d06e219916636d3874e (link)
#151017 Port the rustc dump attributes to the attribute parser c0ca60c72568afff8b8bf0d864942fe3407e1eb7 (link)
#151019 Make Type::of support unsized types 5ad4b78b74d632599783d25676c864aadfd3ba4c (link)
#151031 Support arrays in type reflection b63fb2d847d35ca4761108e834db5abb012b32f4 (link)
#151043 armv7-unknown-linux-uclibceabihf.md: Fix bootstrap.toml syn… f83d05b42deee395602d9c048e2f62c323f83170 (link)
#151052 ui: add regression test for macro resolution ICE (issue #15 1c737eadf38ab6b3fb28485c561eb23dfa243078 (link)
#151053 Reduce flakyness for tests/rustdoc-gui/notable-trait.goml eaa11f11fb2fdf614f7f32e22582baf8aafd6af3 (link)
#151055 Emit error instead of delayed bug when meeting mismatch typ… 82f58a2b812343d2bee53a36568a94debc74b267 (link)

previous master: fcac501a73

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4931e09): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.1%, 0.4%] 9
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.8%, secondary 1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.8% [0.9%, 2.7%] 2
Regressions ❌
(secondary)
3.3% [1.4%, 7.0%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.3%, -2.0%] 3
All ❌✅ (primary) 1.8% [0.9%, 2.7%] 2

Cycles

Results (primary 2.4%, secondary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.1% [-5.4%, -2.1%] 11
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.0%] 1
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [0.0%, 0.0%] 1

Bootstrap: 474.33s -> 474.176s (-0.03%)
Artifact size: 383.14 MiB -> 383.16 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Jan 14, 2026
@GuillaumeGomez GuillaumeGomez deleted the rollup-vIdiReJ branch January 14, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-compiletest Area: The compiletest test runner A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.