Remove unused method DroplessArena::contains_slice#151908
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Jan 31, 2026
Merged
Remove unused method DroplessArena::contains_slice#151908rust-bors[bot] merged 1 commit intorust-lang:mainfrom
DroplessArena::contains_slice#151908rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
Member
|
@bors r=chenyukang |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Jan 31, 2026
Rollup merge of #151908 - Zalathar:contains-slice, r=chenyukang Remove unused method `DroplessArena::contains_slice` - This method was added for #120128. - It became unused in #136593. Checking whether a particular slice is within an arena is a bit of a sketchy operation, so if there's no pressing need for it then I think we're better off not having it lying around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking whether a particular slice is within an arena is a bit of a sketchy operation, so if there's no pressing need for it then I think we're better off not having it lying around.