Rollup of 9 pull requests by JonathanBrouwer · Pull Request #152839 · rust-lang/rust

JonathanBrouwer · 2026-02-19T09:56:42Z

Successful merges:

Use function shims to make sure EII works on apple targets #151733 (Use function shims to make sure EII works on apple targets)
rustc_expand: improve diagnostics for non-repeatable metavars in repetition #152558 (rustc_expand: improve diagnostics for non-repeatable metavars in repetition)
Make all multipart suggestions verbose #152596 (Make all multipart suggestions verbose)
Add CURRENT_RUSTC_VERSION support for Clippy #152815 (Add CURRENT_RUSTC_VERSION support for Clippy)
Port #[rustc_doc_primitive] to the new attribute parser #152733 (Port #[rustc_doc_primitive] to the new attribute parser)
Update enzyme submodule to match upstream #152817 (Update enzyme submodule to match upstream)
explicitly show behavior of <_>::assoc_fn #152819 (explicitly show behavior of <_>::assoc_fn)
fix stale comments left over from ed3711e #152823 (fix stale comments left over from ed3711e)
Enable "View all comments" link feature in triagebot.toml #152824 (Enable "View all comments" link feature in triagebot.toml)

…tition Enhance `NoSyntaxVarsExprRepeat` by suggesting similarly named metavariables, distinguishing repeatable vs non-repeatable bindings, and listing available repeatable variables when no match exists. Co-authored-by: Esteban Küber <esteban@kuber.com.ar> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>

The ShowAlways style of suggestions is usually easier to understand than the inline style.

Use function shims to make sure EII works on apple targets Use function shims to make sure EII works on apple targets (and generally accepts target-arch attributes) Explainer: rust-lang#146348 (comment) Tracking issue: rust-lang#125418

…, r=estebank rustc_expand: improve diagnostics for non-repeatable metavars in repetition Enhance `NoSyntaxVarsExprRepeat` by suggesting similarly named metavariables, distinguishing repeatable vs non-repeatable bindings, and listing available repeatable variables when no match exists.

…petrochenkov Make all multipart suggestions verbose The ShowAlways style of suggestions is usually easier to understand than the inline style.

…py, r=Mark-Simulacrum Add CURRENT_RUSTC_VERSION support for Clippy We've been talking about this since Sept. 2022, finally decided to add the dreaded 1-line diff. cc https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/Using.20CURRENT_RUSTC_VERSION.20in.20clippy.3A.3Aversion.3F/with/516468805 cc https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/Use.20CURRENT_RUSTC_VERSION.20for.20version.20attribute/with/299900715 Overrides the currently unmerged rust-lang/rust-clippy#14299 cc @rust-lang/clippy --- This PR does not modify in any way the needed behaviour of T-Release when releasing (I hope)

@JonathanBrouwer

Port #[rustc_doc_primitive] to the new attribute parser Tracking issue: rust-lang#131229 r? @JonathanBrouwer

@Kobzol

…bzol Update enzyme submodule to match upstream For a while we were carying one extra commit to handle static builds on macos. That commit got upstreamed, so we can drop it (and update to a newer Enzyme while at it). r? @Kobzol Can I get a rollup, please?

@lcnr

…ivooeo explicitly show behavior of <_>::assoc_fn Inspired by a conversation with @lcnr about type relative name resolution. From lcnr: > and i hate the fact that this match isn't exhaustive (hiding the behavior for `<_>::assoc_fn` https://github.com/rust-lang/rust/blob/13c38730d981289cc7ae4cc109fd7756bf83ee67/compiler/rustc_hir_typeck/src/method/probe.rs#L893 This PR changes that match to be exhaustive.

…pratt fix stale comments left over from ed3711e Remove stale overflow comments in core::str. Commit ed3711e introduced stale comments in library/core/src/str/iter.rs. Prior to that commit, the comments explained why `(len + 3)` and `(len + 2)` couldn't overflow. Since the code now uses `div_ceil`, these specific overflow justifications are no longer relevant to the current implementation.

… r=Kobzol Enable "View all comments" link feature in `triagebot.toml` This PR enables triagebot "View all comments" link feature. Documentation: https://forge.rust-lang.org/triagebot/view-all-comments-link.html Example for this PR: [View all comments](https://triage.rust-lang.org/gh-comments/rust-lang/rust/issues/152824)

JonathanBrouwer · 2026-02-19T09:57:42Z

@bors r+ rollup=never p=1
p=1 because there is a bunch of rollup=never PRs, so I want to run two rollup=never PRs before the next rollup
I'll re-make the rollup in 3 hours with more PRs in there

rust-bors · 2026-02-19T09:57:46Z

📌 Commit cad5b1a has been approved by JonathanBrouwer

It is now in the queue for this repository.

JonathanBrouwer · 2026-02-19T13:34:59Z

Trying commonly failed jobs because queue is large
@bors try jobs=x86_64-msvc-1,i686-msvc-1,x86_64-mingw-1,test-various,armhf-gnu,aarch64-apple,x86_64-gnu-llvm-20-3,dist-various-2

Rollup of 9 pull requests try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple try-job: x86_64-gnu-llvm-20-3 try-job: dist-various-2

rust-bors · 2026-02-19T17:18:05Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 10m 51s
Pushing b6bed6f to main...

github-actions · 2026-02-19T17:20:40Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 41198cb (parent) -> b6bed6f (this PR)

Test differences

Show 117 test diffs

Stage 1

[ui] tests/ui/eii/default/call_default_panics.rs: [missing] -> pass (J0)
[ui] tests/ui/macros/typo-in-repeat-expr-2.rs: [missing] -> pass (J0)
[ui] tests/ui/macros/typo-in-repeat-expr.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/eii/default/call_default_panics.rs: [missing] -> ignore (ignored when the operating system is windows) (J1)
[ui] tests/ui/eii/default/call_default.rs: ignore (ignored when the operating system is macos) -> pass (J2)
[ui] tests/ui/eii/default/call_default_panics.rs: [missing] -> ignore (gcc backend is marked as ignore) (J3)
[ui] tests/ui/macros/typo-in-repeat-expr-2.rs: [missing] -> pass (J4)
[ui] tests/ui/macros/typo-in-repeat-expr.rs: [missing] -> pass (J4)
[ui] tests/ui/eii/default/call_default_panics.rs: [missing] -> pass (J5)

Additionally, 108 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b6bed6f2d9f27e15d425958bbd288138ecdff61c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-1: 27m 43s -> 32m 46s (+18.2%)
aarch64-gnu-debug: 1h 9m -> 1h 21m (+17.4%)
aarch64-gnu-llvm-20-1: 56m 44s -> 1h 6m (+17.0%)
i686-gnu-2: 1h 31m -> 1h 46m (+15.9%)
x86_64-rust-for-linux: 45m 23s -> 52m 7s (+14.9%)
aarch64-gnu-llvm-20-2: 47m 41s -> 54m 18s (+13.9%)
dist-aarch64-llvm-mingw: 1h 46m -> 1h 32m (-12.5%)
x86_64-gnu-gcc: 1h 1m -> 1h 9m (+11.9%)
i686-gnu-nopt-1: 2h 9m -> 2h 25m (+11.8%)
i686-gnu-1: 2h 8m -> 2h 23m (+11.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-02-19T17:20:40Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#151733	Use function shims to make sure EII works on apple targets	`381b929490d78cdab8def0c8e9c98f564a0551a4` (link)
#152558	rustc_expand: improve diagnostics for non-repeatable metava…	`53e1348a8edbd20b328c7df44568ab5402134db5` (link)
#152596	Make all multipart suggestions verbose	`66c9ac4966366705916b16998355eb1f60f6f216` (link)
#152733	Port #[rustc_doc_primitive] to the new attribute parser	`87e98a16f9c67c7253068579be56cc33f76f8d51` (link)
#152815	Add CURRENT_RUSTC_VERSION support for Clippy	`9f3bbbca2b87164af7351240697545b4065b4a29` (link)
#152817	Update enzyme submodule to match upstream	`7d1bce4b2aeae6b8dc0216bace612ec2b035410e` (link)
#152819	explicitly show behavior of <_>::assoc_fn	`0ab3cb0da04302fcea2a90262f1e61818848cc8a` (link)
#152823	fix stale comments left over from `ed3711e`	`52d26e97ebaba02ea118e287c702d991ff18d4d0` (link)
#152824	Enable "View all comments" link feature in `triagebot.toml`	`9f6b632defd6030f92d2258af3551a6c46161390` (link)

previous master: 41198cb965

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-02-19T18:00:07Z

Finished benchmarking commit (b6bed6f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	10
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	5
All ❌✅ (primary)	-0.0%	[-0.0%, -0.0%]	10

Bootstrap: 479.676s -> 481.703s (0.42%)
Artifact size: 397.83 MiB -> 397.81 MiB (-0.01%)

rust-bors · 2026-02-19T18:30:56Z

☀️ Try build successful (CI)
Build commit: 38e0ab8 (38e0ab87750db94a41f1e998f6cc44f44eede144, parent: 41198cb9659f3cc7c4a1a3ee97bc4af78bee403e)

jdonszelmann and others added 21 commits February 17, 2026 14:22

codegen-llvm shim function for function aliases for macos

006588a

run tests on apple

d6db0ed

test backtraces

b147997

dont enforce tails

91064bf

Make all multipart suggestions verbose

37684bd

The ShowAlways style of suggestions is usually easier to understand than the inline style.

Add CURRENT_RUSTC_VERSION support for Clippy

6a8c42d

Update enzyme submodule to match upstream

385eaf4

explicitly show behavior of <_>::assoc_fn

0487f58

Port #[rustc_doc_primitive] to the new attribute parser

bd54cd6

fix stale comments left over from ed3711e

4a0f916

Enable "View all comments" link feature in triagebot.toml

0512fb0

Rollup merge of rust-lang#152596 - estebank:multipart_suggestions, r=…

9330931

…petrochenkov Make all multipart suggestions verbose The ShowAlways style of suggestions is usually easier to understand than the inline style.

Rollup merge of rust-lang#152733 - Ozzy1423:attr-doc, r=jdonszelmann

9a90ad4

Port #[rustc_doc_primitive] to the new attribute parser Tracking issue: rust-lang#131229 r? @JonathanBrouwer

rust-bors bot added the rollup A PR which is a rollup label Feb 19, 2026

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 19, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 19, 2026

rust-bors bot merged commit b6bed6f into rust-lang:main Feb 19, 2026
13 checks passed

rustbot added this to the 1.95.0 milestone Feb 19, 2026

This was referenced Feb 19, 2026

Avoid incorrect lifetime suggestion involving sym::anon #148842

Open

rustc_expand: improve diagnostics for non-repeatable metavars #152679

Open

Simpler find_attr!() #152759

Merged

Remove LintDiagnostic #152811

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Rollup of 9 pull requests#152839

Rollup of 9 pull requests#152839
rust-bors[bot] merged 21 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-iPaprtK

JonathanBrouwer commented Feb 19, 2026

Uh oh!

JonathanBrouwer commented Feb 19, 2026 •

edited

Loading

Uh oh!

rust-bors bot commented Feb 19, 2026

Uh oh!

JonathanBrouwer commented Feb 19, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Feb 19, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Feb 19, 2026

Uh oh!

rust-timer commented Feb 19, 2026

Uh oh!

rust-bors bot commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Comments

Conversation

JonathanBrouwer commented Feb 19, 2026

Uh oh!

JonathanBrouwer commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors bot commented Feb 19, 2026

Uh oh!

JonathanBrouwer commented Feb 19, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Feb 19, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Feb 19, 2026

Uh oh!

rust-timer commented Feb 19, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-bors bot commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

JonathanBrouwer commented Feb 19, 2026 •

edited

Loading