fix panic on failure to format generics in enum #6396
+87
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5738
Description
Above issue reports panic when formatting complex enum with generic parameters.
This is because rustfmt simply calls
unwrap()
onRewrite
(RewriteResult
in future), the return value fromformat_generics
.It is better not to panic on this sort of rewrite failure.
Therefore, this pr restores original snippet when we fail to formatgenerics
in enum instead of callingunwrap()
.None
early and then leave entire enum unformatted instead of callingunwrap()
.visit_enum
is refactored withformat_enum
that returnsRewrite
. Later pr will replace this rewrite withRewriteResult
TODO
visitor.rs
?