Pass Accept-Encoding header to origin #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Accept-Encoding header is now passed to the origin so that it can respond with compressed responses. This fixes an inconsistency with the backend, which prefers Brotli compression while CloudFront prefers gzip. Because the header is now passed to the origin, the Brotli-compressed response from the origin is passed through to the client. Previously, CloudFront would fetch uncompressed resources and compress them on the fly using gzip.
Turbo87
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Note that this does not apply to the /assets behavior, since we discovered that this behavior never worked because /assets refers to a fixed path, while /assets/* would have been the correct path pattern... 😅
Passing the header for the regular behavior is still useful for robots.txt and other top-level files though.
jdno
added a commit
to jdno/rust-simpleinfra
that referenced
this pull request
Oct 23, 2023
The custom cache behavior for `/assets` was never used, since the pattern matches only the specific `/assets` URL and not any resources served under it (e.g. `/assets/foo`). This was discovered while investigating the inconsistencies in rust-lang#356. Since the configuration was never used in the first place, we are removing it to remove some complexity.
Mark-Simulacrum
approved these changes
Oct 23, 2023
jdno
added a commit
to jdno/rust-simpleinfra
that referenced
this pull request
Oct 23, 2023
Two recent changes to the CloudFront configuration (rust-lang#356 and rust-lang#357) for crates.io have been merged and deployed to both staging and production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Accept-Encoding header is now passed to the origin so that it can respond with compressed responses.
This fixes an inconsistency with the backend, which prefers Brotli compression while CloudFront prefers gzip. Because the header is now passed to the origin, the Brotli-compressed response from the origin is passed through to the client. Previously, CloudFront would fetch uncompressed resources and compress them on the fly using gzip.
cc @Turbo87