Skip to content

Replace block module with helper functions #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
+501 −825
Open

Replace block module with helper functions #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
30c92d9
Replace block module with helper functions
newpavlov Nov 10, 2025
4a6425b
fix doc
newpavlov Nov 10, 2025
73d7ab3
Fix CI
newpavlov Nov 10, 2025
699271e
Main tests -> Tests
newpavlov Nov 10, 2025
1276031
tweak examples
newpavlov Nov 10, 2025
0dc2440
tweak `read_u*_into` functions
newpavlov Nov 10, 2025
44a48d4
tweak asserts
newpavlov Nov 10, 2025
64e0ee0
Merge branch 'master' into block_buffer
newpavlov Nov 10, 2025
869ae96
Remove `next_u*_via_fill` methods
newpavlov Nov 12, 2025
76959c1
split `fill_bytes_via_next`
newpavlov Nov 12, 2025
4da0ef7
Introduce `Word` trit, add `fill_bytes_via_gen_block`
newpavlov Nov 12, 2025
b486e60
tweak docs
newpavlov Nov 12, 2025
b50f3e3
Add `SeedableRng` impl to utils examples
newpavlov Nov 12, 2025
b020090
Add asserts to `new_buffer`
newpavlov Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Main tests
name: Tests

on:
push:
Expand Down Expand Up @@ -44,7 +44,7 @@ jobs:
with:
toolchain: nightly
- name: rand_core
run: cargo doc --all-features --no-deps
run: cargo doc --no-deps

test:
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -92,12 +92,9 @@ jobs:
- run: ${{ matrix.deps }}
- name: Maybe minimal versions
if: ${{ matrix.variant == 'minimal_versions' }}
run: |
cargo generate-lockfile -Z minimal-versions
run: cargo generate-lockfile -Z minimal-versions
- name: Test rand_core
run: |
cargo test --target ${{ matrix.target }} --no-default-features
cargo test --target ${{ matrix.target }} --features serde
run: cargo test --target ${{ matrix.target }}

test-cross:
runs-on: ${{ matrix.os }}
Expand All @@ -124,9 +121,7 @@ jobs:
- name: Install cross
run: cargo install cross || true
- name: Test
run: |
# all stable features:
cross test --no-fail-fast --target ${{ matrix.target }}
run: cross test --no-fail-fast --target ${{ matrix.target }}

test-miri:
runs-on: ubuntu-latest
Expand All @@ -138,10 +133,7 @@ jobs:
rustup override set nightly
cargo miri setup
- name: Test rand
run: |
cargo miri test
cargo miri test --features=serde
cargo miri test --no-default-features
run: cargo miri test

test-no-std:
runs-on: ubuntu-latest
Expand All @@ -152,7 +144,7 @@ jobs:
with:
target: thumbv6m-none-eabi
- name: Build top-level only
run: cargo build --target=thumbv6m-none-eabi --no-default-features
run: cargo build --target=thumbv6m-none-eabi

test-ios:
runs-on: macos-latest
Expand Down
15 changes: 0 additions & 15 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,3 @@ categories = ["algorithms", "no-std"]
edition = "2024"
rust-version = "1.85"
exclude = ["/.github"]

[package.metadata.docs.rs]
# To build locally:
# RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --all-features --no-deps --open
all-features = true
rustdoc-args = ["--generate-link-to-definition"]
Copy link
Member Author

@newpavlov newpavlov Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need --generate-link-to-definition?

Copy link
Member

@dhardy dhardy Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need or use? I guess it remains an option because it's not truly necessary.

See rust-random/rand#1327.


[package.metadata.playground]
all-features = true

[features]
serde = ["dep:serde"] # enables serde for BlockRng wrapper

[dependencies]
serde = { version = "1.0.103", features = ["derive"], optional = true }
Loading
Loading