fix: output stream on LockedWriters where not closing themselves #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can replicate bug and confirm that this fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting a new S3OutputStream for writing, the object is actually written to s3 when it is
closed(). However, the LockedChannel doesn't not keep track of and close the generated S3OutputStreams when the channel itself is closed.In practice, this only is an issue with BloscCompression, because all the other compressors call close on the S3OutputStream after receiving them, and writing to them. BloscCompression does not though.
This ensures
close()is called on allS3OutputStreams generated by theAmazonS3KeyValueAccess.Not part of this PR, but some more thought should go into the Compressor implementations, to determine whether they should close the output stream they are passed or not. My current thought is that the KVAs should be responsible for closing the OutputStreams that they create. And the underlying calls to write into them by the Compressors should write into them, but not close.