Fix/1.2.1 #534
Merged
Fix/1.2.1 #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move all top-level packages that duplicated names for other packages into org.janelia.saalfeldlab Previously, it was common practice to create an internal package name space that maps to the package which the files should be contributed to (e.g. net.imglib2). However, with the advent of JPMS, merging namespaces with modules no longer works, so it is best to not duplicate the module namespace. Even better is to contribute to the desired projects
displayToMask should use current Viewer to Global, since the display may be over a different spot now e.g. in ShapeInterpolationMode if you paint once, then translate in the slice, and paint again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewer mask calculate display to mask correctly