refactor: some boolean logic

src/main/kotlin/org/janelia/saalfeldlab/fx/actions/Action.kt

@@ -192,17 +192,15 @@ open class Action<E : Event>(val eventType: EventType<E>) {
 
 	private fun testChecks(event: E?): Boolean {
 		return checks.isEmpty() || let {
-			var valid = true
 			for ((description, check) in checks) {
-				valid = valid && check(event)
-				if (!valid) {
+				if (!check(event)) {
 					val startMsg = description?.let { "$it " } ?: ""
 					val msg ="$startMsg(${check::class.java})"
 					logger.trace { "Check: $msg did not pass" }
-					break
+					return false
 				}
 			}
-			valid
+			true
 		}
 	}
 

src/main/kotlin/org/janelia/saalfeldlab/fx/actions/ActionSet.kt

@@ -1,15 +1,12 @@
 package org.janelia.saalfeldlab.fx.actions
 
-import io.github.oshai.kotlinlogging.KLogger
-import io.github.oshai.kotlinlogging.KotlinLogging
 import javafx.event.Event
 import javafx.event.EventHandler
 import javafx.event.EventType
 import javafx.scene.Node
 import javafx.scene.input.*
 import javafx.stage.Window
 import org.janelia.saalfeldlab.fx.event.KeyTracker
-import java.lang.invoke.MethodHandles
 import java.util.function.Consumer
 
 
@@ -192,7 +189,7 @@ open class ActionSet(val name: String, var keyTracker: () -> KeyTracker? = { nul
 
 			/* configure via the callback*/
 			withAction()
-		}.also { addAction(it)}
+		}.also { addAction(it) }
 	}
 
 	/**
@@ -298,7 +295,7 @@ open class ActionSet(val name: String, var keyTracker: () -> KeyTracker? = { nul
 
 			/* configure based on the callback */
 			withAction()
-		}.also { addAction(it)}
+		}.also { addAction(it) }
 	}
 
 	/**
@@ -389,7 +386,7 @@ open class ActionSet(val name: String, var keyTracker: () -> KeyTracker? = { nul
 			try {
 				action(event)
 			} catch (e: Exception) {
-				action.logger.error(e) {"${event.eventType} was valid, but failed" }
+				action.logger.error(e) { "${event.eventType} was valid, but failed" }
 				throw e
 			}
 		} else {