Skip to content

Conversation

@judofyr
Copy link
Contributor

@judofyr judofyr commented Nov 24, 2025

Description

I believe these were leftover from a refactoring by @dcilke related to how we deal with validations in the schema package.

What to review

N/A.

Testing

N/A.

Notes for release

N/A.

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
page-building-studio Ready Ready Preview Comment Nov 25, 2025 9:29am
test-studio Ready Ready Preview Comment Nov 25, 2025 9:29am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
studio-workshop Ignored Ignored Preview Nov 25, 2025 9:29am
test-next-studio Ignored Ignored Nov 25, 2025 9:29am

Copy link
Contributor Author

judofyr commented Nov 24, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

🧪 E2E Preview environment

🔑 Environment Variables for Local Testing

This is the preview URL for the E2E tests: https://e2e-studio-ig882cl2r.sanity.dev

To run the E2E tests locally, you can use the following environment variables, then run pnpm test:e2e --ui to open the Playwright test runner.

💬 Remember to build the project first with pnpm build:e2e.

  SANITY_E2E_PROJECT_ID=ittbm412
  SANITY_E2E_BASE_URL=https://e2e-studio-ig882cl2r.sanity.dev
  SANITY_E2E_DATASET="update depending the project you want to test (pr-11239-chromium-19664689323 || pr-11239-firefox-19664689323 )"
  SANITY_E2E_DATASET_CHROMIUM=pr-11239-chromium-19664689323
  SANITY_E2E_DATASET_FIREFOX=pr-11239-firefox-19664689323

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

📊 Playwright Test Report

Download Full E2E Report

This report contains test results, including videos of failing tests.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

⚡️ Editor Performance Report

Updated Tue, 25 Nov 2025 09:44:19 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.0 efps (44ms) 25.3 efps (40ms) -4ms (-9.2%)
article (body) 32.6 efps (31ms) 36.0 efps (28ms) -3ms (-9.4%)
article (string inside object) 19.8 efps (51ms) 23.3 efps (43ms) -8ms (-14.9%)
article (string inside array) 19.6 efps (51ms) 18.9 efps (53ms) +2ms (+3.9%)
recipe (name) 47.6 efps (21ms) 52.6 efps (19ms) -2ms (-9.5%)
recipe (description) 55.6 efps (18ms) 58.8 efps (17ms) -1ms (-5.6%)
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (9ms) +2ms (-/-%)
singleString (stringField) 66.7 efps (15ms) 62.5 efps (16ms) +1ms (+6.7%)
synthetic (title) 17.1 efps (59ms) 17.2 efps (58ms) -1ms (-0.9%)
synthetic (string inside object) 18.2 efps (55ms) 17.5 efps (57ms) +2ms (+3.6%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 44ms 51ms 73ms 119ms 86ms 10.4s
article (body) 31ms 37ms 94ms 163ms 200ms 7.1s
article (string inside object) 51ms 56ms 73ms 156ms 68ms 7.6s
article (string inside array) 51ms 55ms 61ms 139ms 5ms 7.1s
recipe (name) 21ms 24ms 31ms 81ms 6ms 7.3s
recipe (description) 18ms 22ms 27ms 53ms 2ms 4.4s
recipe (instructions) 7ms 11ms 12ms 16ms 0ms 3.1s
singleString (stringField) 15ms 18ms 21ms 35ms 0ms 7.1s
synthetic (title) 59ms 62ms 69ms 150ms 351ms 14.7s
synthetic (string inside object) 55ms 59ms 64ms 240ms 546ms 7.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 48ms 80ms 122ms 32ms 11.0s
article (body) 28ms 30ms 79ms 168ms 145ms 6.4s
article (string inside object) 43ms 46ms 53ms 147ms 27ms 6.6s
article (string inside array) 53ms 56ms 60ms 140ms 17ms 7.2s
recipe (name) 19ms 22ms 25ms 51ms 0ms 7.8s
recipe (description) 17ms 19ms 23ms 39ms 0ms 4.2s
recipe (instructions) 9ms 11ms 13ms 27ms 0ms 3.2s
singleString (stringField) 16ms 18ms 21ms 46ms 0ms 6.1s
synthetic (title) 58ms 61ms 63ms 134ms 244ms 15.2s
synthetic (string inside object) 57ms 59ms 65ms 263ms 521ms 7.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 44.66% 63598 / 142391
🔵 Statements 44.66% 63598 / 142391
🔵 Functions 48.27% 3397 / 7037
🔵 Branches 79.33% 12918 / 16282
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/@sanity/schema/src/descriptors/convert.ts 92.92% 88.6% 96.15% 92.92% 304-305, 397-398, 406-414, 434-435, 448-455, 511-512, 526-527, 545, 555, 565, 573, 585, 599, 607, 617, 623, 625, 651-652
packages/sanity/src/core/schema/descriptors.ts 100% 100% 100% 100%
Generated in workflow #46206 for commit 2c9fbd7 by the Vitest Coverage Report Action

These are no longer required due to some refactorings we did with
validations.
@judofyr judofyr force-pushed the cldx-4335/remove-unused-options branch from c4a1c9c to 2c9fbd7 Compare November 25, 2025 09:29
@judofyr judofyr force-pushed the cldx-4353/cache-schema-compiler branch from 6c30f2b to 313f899 Compare November 25, 2025 09:29
@judofyr judofyr self-assigned this Nov 25, 2025
@judofyr judofyr requested a review from dcilke November 25, 2025 09:40
@judofyr judofyr marked this pull request as ready for review November 25, 2025 09:40
@judofyr judofyr requested a review from a team as a code owner November 25, 2025 09:40
@judofyr judofyr requested review from bjoerge and removed request for a team November 25, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants