Skip to content

Conversation

@judofyr
Copy link
Contributor

@judofyr judofyr commented Nov 24, 2025

Description

This changes the format of the schema descriptor (i.e. the server-side schema) to automatically detect when a field or array member is reused and then hoists it outside as a separate object.

What to review

  • That the overall algorithm makes sense and is correct. This shouldn't touch anything outside of the schema descriptor stuff.

Testing

  • I should probably add a unit test for the behavior here. I can look into that.

Notes for release

N/A. Still only internal.

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
page-building-studio Ready Ready Preview Comment Nov 25, 2025 4:42pm
test-studio Ready Ready Preview Comment Nov 25, 2025 4:42pm
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
e2e-studio Ignored Ignored Nov 25, 2025 4:42pm
studio-workshop Ignored Ignored Preview Nov 25, 2025 4:42pm
test-next-studio Ignored Ignored Nov 25, 2025 4:42pm

Copy link
Contributor Author

judofyr commented Nov 24, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

🧪 E2E Preview environment

🔑 Environment Variables for Local Testing

This is the preview URL for the E2E tests: https://e2e-studio-o06qz4zs6.sanity.dev

To run the E2E tests locally, you can use the following environment variables, then run pnpm test:e2e --ui to open the Playwright test runner.

💬 Remember to build the project first with pnpm build:e2e.

  SANITY_E2E_PROJECT_ID=ittbm412
  SANITY_E2E_BASE_URL=https://e2e-studio-o06qz4zs6.sanity.dev
  SANITY_E2E_DATASET="update depending the project you want to test (pr-11240-chromium-19676912849 || pr-11240-firefox-19676912849 )"
  SANITY_E2E_DATASET_CHROMIUM=pr-11240-chromium-19676912849
  SANITY_E2E_DATASET_FIREFOX=pr-11240-firefox-19676912849

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

📊 Playwright Test Report

Download Full E2E Report

This report contains test results, including videos of failing tests.

@judofyr judofyr changed the base branch from cldx-4335/remove-unused-options to graphite-base/11240 November 25, 2025 09:28
@judofyr judofyr force-pushed the cldx-4335/dedupe-serialized-fields branch from ffef6a1 to 96cf2d9 Compare November 25, 2025 16:35
@judofyr judofyr force-pushed the graphite-base/11240 branch from c4a1c9c to 2c9fbd7 Compare November 25, 2025 16:35
@judofyr judofyr changed the base branch from graphite-base/11240 to cldx-4335/remove-unused-options November 25, 2025 16:35
@judofyr judofyr self-assigned this Nov 25, 2025
@judofyr judofyr marked this pull request as ready for review November 25, 2025 16:39
@judofyr judofyr requested a review from a team as a code owner November 25, 2025 16:39
@judofyr judofyr requested review from jordanl17 and removed request for a team November 25, 2025 16:39
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

⚡️ Editor Performance Report

Deploying studio and running performance tests…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants