Fix PercentageFeatureSet to respect the assay
parameter
#9686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two small changes to
PercentageFeatureSet
:assay
to theLayers
call on line 1178 of utilities.R.features
parameter contains values not present in the specifiedassay
instead of erroring out.My intent is to introduce a proper test for
PercentageFeatureSet
for now, the following scripts can be used to verify the fixes. Verify thatassay
is being respected:And check that a warning (not an error) is raised when
features
contains bad values: