Update PDST assets #634
Update PDST assets #634
Conversation
✅ Deploy Preview for scientific-python-hugo-theme ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I had been avoiding importing files we aren't using. |
|
I can take those out; this was to test visual changes, to ensure we don't have too big a jump next time we do an ugprade. |
stefanv
force-pushed
the
pdst-asset-update
branch
from
a0e649a
to
844f775
Compare
|
Removed unused files. Applied different fix for missing variable, in response to pydata/pydata-sphinx-theme#1953 |
| @@ -1,3 +1,9 @@ | |||
| // Next line added by SPHT, to add missing bootstrap-provided variables | |||
There was a problem hiding this comment.
I've been adding things like this to the bottom of assets/theme-css/styles.css.
There was a problem hiding this comment.
My plan was to factor #pst-back-to-top out of base/_base.scss and into something like base/_back_to_top.scss or something.
There was a problem hiding this comment.
Why not just keep commenting out // z-index: $zindex-tooltip; like we are currently doing and then factor out the styling we don't need from base/_base.scss?
There was a problem hiding this comment.
I thought the less editing of the original sources needed, the easier it would be to stay in sync.
No description provided.