Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PDST assets #634

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update PDST assets #634

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56b1e59
Update PDST assets
stefanv Aug 14, 2024
844f775
Fix missing bootstrap variable
stefanv Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions assets/theme-css/pst/pydata-sphinx-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
// Next line added by SPHT, to add missing bootstrap-provided variables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been adding things like this to the bottom of assets/theme-css/styles.css.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My plan was to factor #pst-back-to-top out of base/_base.scss and into something like base/_back_to_top.scss or something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just keep commenting out // z-index: $zindex-tooltip; like we are currently doing and then factor out the styling we don't need from base/_base.scss?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the less editing of the original sources needed, the easier it would be to stay in sync.

$zindex-tooltip: 1080;

// The rest of file comes verbatim from PDST, with unused modules
// commented.

//// Import Bootstrap core
//@import "~bootstrap/scss/functions";
@import "variables/bootstrap";
Expand Down