506 ccp reoptimize inference #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 449-cp-with-conditional-guarantees #507 +/- ##
======================================================================
Coverage ? 100.00%
======================================================================
Files ? 73
Lines ? 6639
Branches ? 1129
======================================================================
Hits ? 6639
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Damien-Bouet
commented
Aug 9, 2024
Comment on lines
+56
to
+63
| Warning: | ||
|
|
||
| In this tutorial, we use ``unsafe_approximation=True`` to have a faster | ||
| computation (because Read The Docs examples require fast computation). | ||
| This mode use an approximation, which make the inference (``predict``) faster, | ||
| but induce a small miscoverage. It is recommanded not to use it, or be | ||
| very careful and empirically check the coverage and a test set. | ||
|
|
There was a problem hiding this comment.
I needed to temporally use the old method (with unsafe_approximation=True), which doesn't have the theoretical guarantees, otherwise the documentation was in timeout. I will need to change the dataset, to have faster computation, or transform this .py tuto in the doc, into a true notebook, which is not run during the documentation build.
Indeed, showing in the first tuto, the deprecated method which doesn't have guarantees is not a good idea.
thibaultcordier
merged commit a3664f5
into
449-cp-with-conditional-guarantees
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a re-optimization for each X_n+1 at inference time (in the
predict). The oldsplitmethod is still available withmapie.predict(X, unsafe_approximation=True).Fixes #506
Type of change
Please remove options that are irrelevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
make lintmake type-checkmake testsmake coveragemake doc