-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
506 ccp reoptimize inference #507
Merged
thibaultcordier
merged 13 commits into
449-cp-with-conditional-guarantees
from
506-ccp-reoptimize-inference
Oct 22, 2024
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
926d3b6
Merge branch '449-cp-with-conditional-guarantees' into 506-ccp-reopti…
Damien-Bouet 0ecabba
UPD: re optimize at inference time and add unsafe mode for old method
Damien-Bouet 171cd6d
Merge branch '449-cp-with-conditional-guarantees' into 506-ccp-reopti…
Damien-Bouet 2b43867
FIX: tests
Damien-Bouet b054bfa
REMOVE warning about stochastic behavior
Damien-Bouet 096b4b4
UPD: add :class: tag in docstrings
Damien-Bouet 1ded613
UPD: optimize starting from n points value
Damien-Bouet 600047b
UPD: remove commented section
Damien-Bouet 90f865f
UPD: shorten giibs result reproduction duration
Damien-Bouet 038f863
UPD: activate unsafe_approximation in the doc example
Damien-Bouet 2788dbd
Merge branch '449-cp-with-conditional-guarantees' into 506-ccp-reopti…
6a35307
Add approximation boolean for classification
48b8730
UPD: typo
thibaultcordier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to temporally use the old method (with
unsafe_approximation=True
), which doesn't have the theoretical guarantees, otherwise the documentation was in timeout. I will need to change the dataset, to have faster computation, or transform this .py tuto in the doc, into a true notebook, which is not run during the documentation build.Indeed, showing in the first tuto, the deprecated method which doesn't have guarantees is not a good idea.