Skip to content

SGW has started using timestamps which sometimes include fractional seconds#32

Merged
scottmconway merged 2 commits intoscottmconway:mainfrom
RomanHargrave:roman/fix-timestamp-parsing
Apr 29, 2025
Merged

SGW has started using timestamps which sometimes include fractional seconds#32
scottmconway merged 2 commits intoscottmconway:mainfrom
RomanHargrave:roman/fix-timestamp-parsing

Conversation

@RomanHargrave
Copy link
Copy Markdown
Contributor

See title. This morning I started getting errors from a favorites list which contained a mix of %H:%M:%S and %H:%M:%S.%f times. Maybe they will pick one and stick with it eventually.

Copy link
Copy Markdown
Owner

@scottmconway scottmconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run black?

Additionally, it would make sense to define date_format as a class variable. L405 could be changed to date_format = self.date_format and then modified further if needed.

@scottmconway scottmconway merged commit fa54b81 into scottmconway:main Apr 29, 2025
1 check passed
@scottmconway
Copy link
Copy Markdown
Owner

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants