Skip to content

SGW has started using timestamps which sometimes include fractional seconds #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scottmconway merged 2 commits into from
Apr 29, 2025
Merged

SGW has started using timestamps which sometimes include fractional seconds #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
560087c
Support for the new and exciting ISO-8601-GW standard
RomanHargrave Apr 28, 2025
9e66a06
Lint
RomanHargrave Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion bid_sniper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ def __init__(self, config: Dict, dry_run: bool = False) -> None:
# if set, the default note to assign favorites that don't have a note
self.default_note = self.config["bid_sniper"].get("favorite_default_note", None)

self.date_format = "%Y-%m-%dT%H:%M:%S"

# logging setup
logging_conf = config.get("logging", dict())
self.logger = logging.getLogger("shopgoodwill_bid_sniper")
Expand Down Expand Up @@ -398,11 +400,19 @@ async def main_loop(self) -> None:
if item_id in self.scheduled_tasks:
continue

# SGW has been including microseconds inconsistently,
# and one is liable to see '2025-04-29T23:00:17.45' in
# the same response as '2025-05-01T22:09:00'
end_time = favorite_info["endTime"]
date_format = self.date_format
if "." in end_time:
date_format += ".%f"

# so close but yet so far away from ISO-8601
# SGW simply trims the "PDT" (or PST?) off of the timestamps
# TODO validate that the site only uses a single timezone!
end_time = (
datetime.datetime.fromisoformat(favorite_info["endTime"])
datetime.datetime.strptime(end_time, date_format)
.replace(tzinfo=ZoneInfo("US/Pacific"))
.astimezone(ZoneInfo("Etc/UTC"))
)
Expand Down