QT Fred Boillerplate Removal and Memory Safety #6493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alog" This reverts commit 2a7806d.
wookieejedi
added
cleanup
Goober5000
requested changes
Dec 30, 2024
Goober5000
approved these changes
Dec 30, 2024
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #6457 and half of #6458. Adds Qt::WA_deleteonclose to all dialogs. and adds a function in misson/utils for a generic close confirmation. Which has been added to most dialogs which did not have there own custom close checks.
This did require moving the modified variable into the abstractdialogbox class so this pull request can't be broken up. Fortunately most of this pull request is copy and paste across all dialogs so while the number of files modified is huge the actual changes are rather small.