Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for derived types for configuration #1223

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

nadavge
Copy link
Contributor

@nadavge nadavge commented Mar 4, 2024

Currently if we want to use a derived type for one of the configuration fields, we can't do that. This aims to permit it.

We were using a class that overrides datetime for our tests, and needed this change.

@Gallaecio Gallaecio merged commit f659364 into scrapinghub:master Mar 5, 2024
13 checks passed
@Gallaecio
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants