New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for derived types for configuration #1223

Merged

Gallaecio merged 2 commits into scrapinghub:master from nadavge:master

Mar 5, 2024

Contributor

nadavge commented Mar 4, 2024

Currently if we want to use a derived type for one of the configuration fields, we can't do that. This aims to permit it.

We were using a class that overrides datetime for our tests, and needed this change.


          Check for derived types for configuration

00a7c16

Gallaecio approved these changes

View reviewed changes


          Fix misuse of variable type instead of variable in type check

776a10c

Gallaecio merged commit f659364 into scrapinghub:master

13 checks passed

Member

Gallaecio commented Mar 5, 2024

Thank you!

majikman111 mentioned this pull request

Parse settings do not accept subclass types #1115

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet