Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for derived types for configuration #1223

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Check for derived types for configuration #1223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00a7c16
Check for derived types for configuration
nadavge Mar 4, 2024
776a10c
Fix misuse of variable type instead of variable in type check
nadavge Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dateparser/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def check_settings(settings):
setting_props = settings_values[setting_name]

# check type:
if not setting_type == setting_props["type"]:
if not isinstance(setting_value, setting_props["type"]):
raise SettingValidationError(
'"{}" must be "{}", not "{}".'.format(
setting_name, setting_props["type"].__name__, setting_type.__name__
Expand Down
Loading