fix: make generated script executable #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admon84
reviewed
Feb 8, 2025
| nodeResolve(), | ||
| typescript({ tsconfig: './tsconfig.json' }) | ||
| typescript({ tsconfig: './tsconfig.json' }), | ||
| shebang({ include: "src/clientApp.ts" }), |
There was a problem hiding this comment.
I wonder if this can be done with a banner in the output section instead of adding the shebang plugin
banner: '#!/usr/bin/env node'
There was a problem hiding this comment.
It's not only about the banner, we need a chmod +x to happen to the output, otherwise you get a EPERM error when trying to exec that on a *nix platform. Like, node ./clientApp.js would work (since the thing being exec'd is node, which has its +x bit set), but ./clientApp.js wouldn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the
dist/clientApp.jsscript is properly marked as +x, which fixes an issue withnpxfailing to execute it.