Skip to content

fix: make generated script executable #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

fix: make generated script executable #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cc5693
fix ESlint being unhappy with the rollup config file
tiennou Feb 7, 2025
1e8737e
fix the final script not being executable
tiennou Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": "tsconfig.json",
"project": "tsconfig.eslint.json",
"sourceType": "module"
},
"plugins": [
Expand Down
57 changes: 53 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"prettier": "^3.3.2",
"rimraf": "^5.0.7",
"rollup": "^4.18.0",
"rollup-plugin-shebang-bin": "^0.1.0",
"typescript": "5.5.2"
},
"dependencies": {
Expand Down
5 changes: 4 additions & 1 deletion rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
import typescript from '@rollup/plugin-typescript';
import { nodeResolve } from '@rollup/plugin-node-resolve';
import shebang from 'rollup-plugin-shebang-bin'

/** @type {import('rollup').RollupOptions} */
const baseConfig = {
output: {
dir: 'dist',
format: 'esm'
},
plugins: [
nodeResolve(),
typescript({ tsconfig: './tsconfig.json' })
typescript({ tsconfig: './tsconfig.json' }),
shebang({ include: "src/clientApp.ts" }),
Copy link
Member

@admon84 admon84 Feb 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this can be done with a banner in the output section instead of adding the shebang plugin

banner: '#!/usr/bin/env node'

Copy link
Author

@tiennou tiennou Feb 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not only about the banner, we need a chmod +x to happen to the output, otherwise you get a EPERM error when trying to exec that on a *nix platform. Like, node ./clientApp.js would work (since the thing being exec'd is node, which has its +x bit set), but ./clientApp.js wouldn't.

],
external: id => /node_modules/.test(id)
};
Expand Down
1 change: 0 additions & 1 deletion src/clientApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/usr/bin/env node
import views from '@ladjs/koa-views';
import { ArgumentParser } from 'argparse';
import chalk from 'chalk';
Expand Down
7 changes: 7 additions & 0 deletions tsconfig.eslint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"extends": "./tsconfig.json",
"include": [
"src",
"rollup.config.mjs"
]
}
Loading