fix(docker): multiple fixes to docker_backend_local.yaml #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruch
changed the title
fruch
changed the title
* fix case back to older monitoring stack, cause of scylladb/scylla-monitoring#2246 * rate limit also prepare phase * disable argus reporting for this case
when there a topology change during this function being called it can fail like the following: ``` File ".../sdcm/stress_thread.py", line 298, in _run_cs_stress stress_cmd = self.create_stress_cmd(cmd_runner, keyspace_idx, loader) File ".../sdcm/stress_thread.py", line 187, in create_stress_cmd stress_cmd = self.adjust_cmd_connection_options(stress_cmd, loader, cmd_runner) File ".../sdcm/stress_thread.py", line 159, in adjust_cmd_connection_options stress_cmd = self.adjust_cmd_node_option(stress_cmd, loader, cmd_runner) File ".../sdcm/stress_thread.py", line 142, in adjust_cmd_node_option rack_names = self.loader_set.get_rack_names_per_datacenter_and_rack_idx(db_nodes=self.node_list) File ".../sdcm/cluster.py", line 3224, in get_rack_names_per_datacenter_and_rack_idx rack_names_mapping[(region, rack)] = status[nodes[0]]['rack'] ``` since one of the nodes it might use as a key, isn't in `nodetool status` anymore. so we using only the intersection of the nodes from the argument and from the response of `nodetool status`
fruch
force-pushed
the
fix_docker_backend
branch
from
859a469
to
ecc38a5
Compare
this logger was filter only lines that had scylla in them and our docker logs doesn't have the scylla compoent printed in all of them, so we were loosing lots of the relevent log information, we should log everything the docker output has.
since our monitoring node in docker backend isn't a real instance, we don't need the tunneling, and we can run it locally as is some nemesis code it decorated with functions that generate grafana screenshots, hence we need this fixed
fruch
force-pushed
the
fix_docker_backend
branch
from
d08b301
to
5014b13
Compare
|
Last commit here breaks collecting grafana screenshots: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)