feat: Generalised Minkowski Metric (L_p norm)#291
Open
cbueth wants to merge 18 commits intosdd:v5.x.xfrom
Open
feat: Generalised Minkowski Metric (L_p norm)#291cbueth wants to merge 18 commits intosdd:v5.x.xfrom
cbueth wants to merge 18 commits intosdd:v5.x.xfrom
Conversation
…lidean distance metrics
- deprecate `rd_update` with `D::accumulate` for consistent handling of sum-based and max-based metrics - conditional logic for SIMD (L1/L2) and general L∞ - differentiate distance accumulation behaviour
- integration `nearest_n` tests (Chebyshev, Manhattan, SquaredEuclidean).
…doc, add Gaussian scenario to tests
… trait - improve test coverage
…fy usage scenarios
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5.x.x #291 +/- ##
==========================================
+ Coverage 94.89% 95.07% +0.17%
==========================================
Files 54 54
Lines 5685 6298 +613
Branches 5685 6298 +613
==========================================
+ Hits 5395 5988 +593
- Misses 273 286 +13
- Partials 17 24 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reopen for #287 after integrating the feedback from #286 . See the description in the initial PR. All tests still pass locally.
Closes #287