Skip to content

feat: Generalised Minkowski Metric (L_p norm) #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbueth wants to merge 18 commits into
base: v5.x.x
Choose a base branch
from
Open

feat: Generalised Minkowski Metric (L_p norm) #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
47db176
test: Add coverage for Manhattan and Squared Euclidean distance metrics
cbueth Feb 5, 2026
8178908
feat: Add Chebyshev distance metric and test coverage
cbueth Feb 5, 2026
57dff79
test: add integration tests for Chebyshev, Manhattan, and Squared Euc…
cbueth Feb 7, 2026
b1fe052
inclusive radius matching and leaf note remainder loops
cbueth Feb 7, 2026
4a59cb8
fix over-pruning for L_inf
cbueth Feb 7, 2026
28859a9
Add `D::accumulate` and `D::IS_MAX_BASED`
cbueth Feb 7, 2026
c8dcb3e
feat: add fixed Chebyshev distance metric
cbueth Feb 7, 2026
3f32f6b
refactor: in-loop accumulation for max-based metrics
cbueth Feb 7, 2026
93b98c1
unify distance accumulation logic with `D::accumulate`
cbueth Feb 7, 2026
c934656
remove `D::IS_MAX_BASED`, unify heap logic, improve `DistanceMetric` …
cbueth Feb 7, 2026
fa3361f
change test comment & lint
cbueth Feb 7, 2026
7ebb80b
refactor: make metric property tests reusable
cbueth Feb 7, 2026
44a0f1e
chore: add default implementation of `accumulate` to `DistanceMetric`…
cbueth Feb 12, 2026
5c424bb
feat: add Minkowski and MinkowskiF64 distance metrics with tests
cbueth Feb 8, 2026
cca6e57
compile-time validations and doc aliases for Minkowski metrics, clari…
cbueth Feb 8, 2026
8970913
integration `nearest_n` tests (Minkowski, MinkowskiF64) with paramete…
cbueth Feb 8, 2026
7adffe8
chore: saturating add for fixed metrics
cbueth Feb 13, 2026
d7bebf0
Merge branch 'feature/chebychev' into feature/minkowski
cbueth Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/generate_best_n_within.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ macro_rules! generate_best_n_within {
rd,
);

rd = Axis::rd_update(rd, D::dist1(new_off, old_off));
rd = D::accumulate(rd, D::dist1(new_off, old_off));

if rd <= radius {
off[split_dim] = new_off;
Expand Down
4 changes: 2 additions & 2 deletions src/common/generate_nearest_n.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ macro_rules! generate_nearest_n {
rd,
);

rd = Axis::rd_update(rd, D::dist1(new_off, old_off));
rd = D::accumulate(rd, D::dist1(new_off, old_off));

if Self::dist_belongs_in_heap(rd, results) {
off[split_dim] = new_off;
Expand Down Expand Up @@ -112,7 +112,7 @@ macro_rules! generate_nearest_n {
}
}

#[inline]
#[inline(always)]
fn dist_belongs_in_heap(dist: A, heap: &BinaryHeap<NearestNeighbour<A, T>>) -> bool {
heap.is_empty() || dist < heap.peek().unwrap().distance || heap.len() < heap.capacity()
}
Expand Down
4 changes: 2 additions & 2 deletions src/common/generate_nearest_n_within_unsorted.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ macro_rules! generate_nearest_n_within_unsorted {
rd,
);

rd = Axis::rd_update(rd, D::dist1(new_off, old_off));
rd = D::accumulate(rd, D::dist1(new_off, old_off));

if rd <= radius {
off[split_dim] = new_off;
Expand Down Expand Up @@ -116,7 +116,7 @@ macro_rules! generate_nearest_n_within_unsorted {
.for_each(|(idx, entry)| {
let distance = D::dist(query, transform(entry));

if distance < radius {
if distance <= radius {
let item = unsafe { leaf_node.content_items.get_unchecked(idx) };
let item = *transform(item);

Expand Down
2 changes: 1 addition & 1 deletion src/common/generate_nearest_one.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ macro_rules! generate_nearest_one {
nearest = nearest_neighbour;
}

rd = Axis::rd_update(rd, D::dist1(new_off, old_off));
rd = D::accumulate(rd, D::dist1(new_off, old_off));

if rd <= nearest.distance {
off[split_dim] = new_off;
Expand Down
4 changes: 2 additions & 2 deletions src/common/generate_within_unsorted.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ macro_rules! generate_within_unsorted {
rd,
);

rd = Axis::rd_update(rd, D::dist1(new_off, old_off));
rd = D::accumulate(rd, D::dist1(new_off, old_off));

if rd <= radius {
off[split_dim] = new_off;
Expand Down Expand Up @@ -98,7 +98,7 @@ macro_rules! generate_within_unsorted {
.for_each(|(idx, entry)| {
let distance = D::dist(query, transform(entry));

if distance < radius {
if distance <= radius {
let item = unsafe { leaf_node.content_items.get_unchecked(idx) };
let item = *transform(item);

Expand Down
4 changes: 2 additions & 2 deletions src/common/generate_within_unsorted_iter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ macro_rules! generate_within_unsorted_iter {
rd,
);

rd = Axis::rd_update(rd, D::dist1(new_off, old_off));
rd = D::accumulate(rd, D::dist1(new_off, old_off));

if rd <= radius {
off[split_dim] = new_off;
Expand Down Expand Up @@ -108,7 +108,7 @@ macro_rules! generate_within_unsorted_iter {
.for_each(|(idx, entry)| {
let distance = D::dist(query, transform(entry));

if distance < radius {
if distance <= radius {
let item = unsafe { leaf_node.content_items.get_unchecked(idx) };
let item = *transform(item);

Expand Down
Loading
Loading