Update UML diagrams to the new version of PlantUML #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to submit a new iteration when this PR is ready for review. See this repository's contribution guide for more information. |
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
=========================================
Coverage 74.03% 74.03%
Complexity 423 423
=========================================
Files 71 71
Lines 1290 1290
Branches 127 127
=========================================
Hits 955 955
Misses 301 301
Partials 34 34 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eclipse-Dominator
force-pushed
the
upgrade-plant-uml
branch
from
925b7f7
to
923e99a
Compare
PlantUML(1.2023.2) introduced a change in behavior when rendering diagrams. This causes some of the diagrams to be rendered incorrectly or fail to compile. Diagrams are also being rendered in a different theme due to a change in the default color theme. Therefore, some of the PlantUML code and images need to be updated to ensure functionality and consistency. The old color scheme will also be applied as some of the manual color changes are based on it. Let's * update PlantUML code to ensure they can be rendered properly * update diagrams to use the original theme to fit the manual theme changes * update the diagrams to ensure consistency between the PlantUML code and the rendered image
Eclipse-Dominator
force-pushed
the
upgrade-plant-uml
branch
from
923e99a
to
8daeab4
Compare
PlantUML diagrams in doc/diagrams/plantuml are not used in the project. The rendered image of this code are being used in SE-EDU's plantUml tutorial (https://se-education.org/guides/tutorials/plantUml.html). As these images are not part of AB3, let's remove these diagrams.
v1@Eclipse-Dominator submitted v1 for review. Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level3.git refs/pr/201/1/head:BRANCHNAMEwhere |
|
Closing in favor of #202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200
Alternative ver where the newer theme is used instead: #202
As of PlantUML 1.2023.2, there has been a change in behavior when rendering PlantUML diagrams. This causes some of the PlantUML diagrams to be rendered incorrectly or fail to compile. Some of the diagrams are also being rendered in a different theme due to a change in the default color theme.
Therefore some of the PlantUML code and images need to be updated to ensure functionality as well as consistency. The old color scheme also needs to be applied as some of the manual color changes are based on the older theme.