Upgrade plant uml new theme

[Eclipse-Dominator]

Fixes #200

Alternative to #201 where the new default theme is used instead of the old rose theme.

PlantUML(1.2023.2) introduced a change in behavior when rendering
diagrams. This causes some of the diagrams to be rendered incorrectly or
fail to compile. Diagrams are also being rendered in a different theme
due to a change in the default color theme.

Therefore, some of the PlantUML code and images need to be updated to
ensure functionality and consistency.

Let's

• update PlantUML code to ensure they can be rendered properly
• update the diagrams to ensure consistency between the PlantUML code
  and the rendered image

[canihasreview]

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

[codecov]

Codecov Report

Merging #202 (aafaef4) into master (a976ec9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #202   +/-   ##
=========================================
  Coverage     74.03%   74.03%           
  Complexity      423      423           
=========================================
  Files            71       71           
  Lines          1290     1290           
  Branches        127      127           
=========================================
  Hits            955      955           
  Misses          301      301           
  Partials         34       34           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[canihasreview]

v1

@Eclipse-Dominator submitted v1 for review.

• [v1 1/2] Update UML diagrams to resolve rendering issues
• [v1 2/2] Remove unused PlantUML diagrams

(📚 Archive)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/202/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

[damithc]

@Eclipse-Dominator do you see any diagrams that is not optimal under the default theme (compared to the old theme)?

For the following, I'm not sure why the Storage component appears in a different color.

But while we are at it, we can actually color each of those two boxes with a very light shade of the main color we use the same components in the architecture diagram.

[Eclipse-Dominator]

@damithc I believe there is some rendering logic for Packages that contain classes and Packages that doesn't. The Model package above contains a hidden Class but the Storage package doesn't. This causes a change in rendering.

do you see any diagrams that is not optimal under the default theme (compared to the old theme)?

Mainly it would be the UndoRedoState diagrams.

The main differences between the 2 themes are:

• Classes are no longer colored
• Borders, arrows and lines are black by default (previously red)
• Change in the color of note

[damithc]

The main differences between the 2 themes are:

• Classes are no longer colored
• Borders, arrows and lines are black by default (previously red)
• Change in the color of note

Personally, I think the old theme is slightly easier to read. But given that using the defaults is less work, I'm fine to switch to the new theme despite the slight loss of readability.

[Eclipse-Dominator]

Personally, I think the old theme is slightly easier to read. But given that using the defaults is less work, I'm fine to switch to the new theme despite the slight loss of readability.

@damithc It will still be the same amount of work as all the formatting the diagram component to the AB3 style still require the student to import style.puml. So there are actually no difference whether we are using the new theme or the old theme

[canihasreview]

v2

@Eclipse-Dominator submitted v2 for review.

• [v2 1/2] Update UML diagrams to resolve rendering issues
• [v2 2/2] Remove unused PlantUML diagrams

(📚 Archive) (📈 Interdiff between v1 and v2) (📈 Range-Diff between v1 and v2)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/202/2/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

[damithc]

Looks good.
The following part of the commit message can be shortened as it is mostly stating the obvious:

Therefore, some of the PlantUML code and images need to be updated to
ensure functionality and consistency.

Let's
 * update PlantUML code to ensure they can be rendered properly
 * update the diagrams to ensure consistency between the PlantUML code
   and the rendered image

Something like this?

Let's update the PlantUML diagrams accordingly.

[damithc]

@se-edu/tech-team-level1 for your review ...

[dlimyy]

Overall, LGTM! Just one minor suggestion

[dlimyy]

For the new image, it would be good if the association role filtered can be shifted to the association pointing from ModelManager to Person(similar to the old image) since it is the ModelManager that contains the filtered list of Person.

[Eclipse-Dominator]

Added an invisible class to separate the 2 labels.

[canihasreview]

v3

@Eclipse-Dominator submitted v3 for review.

• [v3 1/2] Update UML diagrams to resolve rendering issues
• [v3 2/2] Remove unused PlantUML diagrams

(📚 Archive) (📈 Interdiff between v2 and v3) (📈 Range-Diff between v2 and v3)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/202/3/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

[SPWwj]

The PR looks good, as it standardizes the hexadecimal color from 5 to 6 digits. However, due to this change, the style of some diagrams may not look as good as before. It would be better if we could adjust the style to make the diagrams easier to read.

1. I've noticed that previously all labels were bold, but in the new version, they are not. It might be beneficial to restore the bold formatting for better readability.

2. The default color of the lines is not the same as in the previous version, but I think this is acceptable as it doesn't significantly impact the understanding of the diagrams.

[SPWwj]

The style of this diagram is slightly different. Can we adjust the CSS to make the text and nodes stand out, making them easier to read?

[SPWwj]

The original diagram had better contrast and was easier to read. Can we adjust the CSS to make it similar to the original diagram?

[Eclipse-Dominator]

I wasn't able to directly make font thicker but I compensated by bumping the font size slightly to make the font appear clearer.

[canihasreview]

v4

@Eclipse-Dominator submitted v4 for review.

• [v4 1/2] Update UML diagrams to resolve rendering issues
• [v4 2/2] Remove unused PlantUML diagrams

(📚 Archive) (📈 Interdiff between v3 and v4) (📈 Range-Diff between v3 and v4)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/202/4/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.