-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13] Switch to GitHub actions for E2E tests #577
Conversation
1fbbfa7
to
b50797f
Compare
@@ -14,5 +14,11 @@ object BackupScreen : UiDeviceScreen<BackupScreen>() { | |||
|
|||
val backupLocationButton = findObject { text("Backup location") } | |||
|
|||
val backupSwitch = findObject { text("Backup my apps") } | |||
|
|||
val internalStorageButton = findObject { textContains("Android SDK built for") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe nice to use the viewID or something more generic here, so it will work on different devices as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but for some reason I couldn't get any elements selected by resource id.
Struggled with it for a long time before giving up for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e.:
val internalStorageButton = findObject {
resourceIdMatches(".*titleView.*")
}
or any combination of this just ... doesn't work 😞
assert(!restoreResultValue.hasFailed) { "Failed to install packages" } | ||
// TODO: Fix this, with current test an app or two breaks on install with AOSP image. | ||
// Just need to update the test data to work with the AOSP image. | ||
// assert(!restoreResultValue.hasFailed) { "Failed to install packages" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should find out why this is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added support for uploading logcat logs along with the screen recordings. The error is:
10-11 01:53:53.696 1974 1974 D ApkInstaller: Received result for org.torproject.torbrowser: success=false INSTALL_FAILED_NO_MATCHING_ABIS: INSTALL_FAILED_NO_MATCHING_ABIS: Failed to extract native libraries, res=-113
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And for the second package the same thing:
10-11 01:53:50.877 1974 1974 D ApkInstaller: Received result for org.ca.squawker: success=false INSTALL_FAILED_NO_MATCHING_ABIS: INSTALL_FAILED_NO_MATCHING_ABIS: Failed to extract native libraries, res=-113
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backups were taken on google_apis
emulators with x86_64
architecture, so that's a bit confusing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be that the backup used a different architecture and not a universal APK? So if the APK had only arm binaries and now we are on x86, the errors would be expected.
@@ -30,3 +30,6 @@ $ADB push $ROOT_PROJECT_DIR/app/build/outputs/apk/release/app-release.apk /syste | |||
echo "Installing Seedvault permissions..." | |||
$ADB push $ROOT_PROJECT_DIR/permissions_com.stevesoltys.seedvault.xml /system/etc/permissions/privapp-permissions-seedvault.xml | |||
$ADB push $ROOT_PROJECT_DIR/allowlist_com.stevesoltys.seedvault.xml /system/etc/sysconfig/allowlist-seedvault.xml | |||
|
|||
echo "Setting Seedvault transport..." | |||
$ADB shell bmgr transport com.stevesoltys.seedvault.transport.ConfigurableBackupTransport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally, the system did this itself, but now I am also seeing that this doesn't seem to work anymore on 14. Not sure why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an OS patch for this. It's still pending a port.
Should pick #580 |
can this be closed then? in favor of #582 ? |
We aren't maintaining 13 anymore, so I'm closing this. |
#569 but for
android-13
.