Fix and improve E2E tests #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesoltys
force-pushed
the
feature/e2e-test-logs
branch
14 times, most recently
from
a221b2b
to
f944c4d
Compare
stevesoltys
changed the title
stevesoltys
force-pushed
the
feature/e2e-test-logs
branch
3 times, most recently
from
700af9d
to
3a1e77b
Compare
|
How does this relate to #577 ? |
|
@grote it'll likely replace most of it |
|
Slightly unrelated: we should probably update the status badge in the README. |
stevesoltys
force-pushed
the
feature/e2e-test-logs
branch
4 times, most recently
from
0ef70a1
to
7bd0852
Compare
grote
approved these changes
Oct 17, 2023
| name: seedvault_test_videos | ||
| path: seedvault_test_videos/**/*.mp4 | ||
| name: ${{ matrix.emulator_type }}-${{ matrix.android_target }}-results | ||
| path: seedvault_test_results/**/* |
There was a problem hiding this comment.
Is this uploading logcat as well?
| - name: Assemble tests | ||
| run: ./gradlew :app:assembleAndroidTest | ||
|
|
||
| - name: Run tests | ||
| uses: reactivecircus/android-emulator-runner@v2 | ||
| uses: Wandalen/[email protected] |
There was a problem hiding this comment.
we need to retry 3 times? Are things this flaky? do we know where the flakyness comes from?
There was a problem hiding this comment.
I'm not sure if we do, just leaving this for now. If we see consistency we can remove it, if not we can fix the flakiness.
stevesoltys
force-pushed
the
feature/e2e-test-logs
branch
from
7bd0852
to
551538f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.