Implement a native WebDAV plugin #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grote
force-pushed
the
webdav
branch
2 times, most recently
from
f5dc246
to
e92c9c9
Compare
We use the same root folder for app and files backup. App backup usually creates the root folder, but if only storage backup is used, it will be missing and needs to be created.
This is especially useful for WebDAV storage where the user can supply whatever URL and before proceeding, we need to know whether that URL and the provided credentials are actually working.
Mostly renaming for clarity.
in preparation for generalization
and allow changing them dynamically. So far plugins were injected into the dependency graph and couldn't be changed at runtime, only their config could. Now we have the infrastructure in place to really allow for more than one plugin.
including ViewModel and StoragePluginManager logic
this is important, so we don't allow more than one backup running at the same time and not swapping out the storage while one is running. Previously, we had some bare bones tracking, but nothing precise.
it may be WebDAV now
stevesoltys
previously approved these changes
Apr 30, 2024
app/src/main/java/com/stevesoltys/seedvault/plugins/StoragePluginManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/plugins/StoragePluginManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/settings/SettingsManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/plugins/webdav/WebDavStorage.kt
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/plugins/webdav/WebDavStoragePlugin.kt
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/storage/WebDavStoragePlugin.kt
Outdated
Show resolved
Hide resolved
stevesoltys
approved these changes
May 4, 2024
|
Feel free to merge whenever. LGTM. |
stevesoltys
reviewed
May 4, 2024
|
|
||
| fun getConfig(): WebDavConfig { | ||
| assumeFalse(System.getenv("NEXTCLOUD_URL").isNullOrEmpty()) | ||
| return WebDavConfig( |
There was a problem hiding this comment.
Another option could be something like WireMock if we didn't want to actually depend on an external service for tests.
But this is probably easier and likely provides better coverage anyways..
There was a problem hiding this comment.
Yeah, I had considered mocking the HTTP interactions, but this gets us to low-level DAV and XML details, I didn't want to get into. That is why we are using a DAV library after all. I also thought about some built-in WebDAV capable webserver only used for tests, but couldn't find anything sane and easy, so I went with testing against a real server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR does the following:
Closes #317