Correct the name of the GitHub Actions jobs and make sure to test all static/shared combinations #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shared job should not disable pkg-config usage and should be the one that does a Harfbuzz build. The static job should disable pkg-config and should not do its own Harfbuzz build outside of the `harfbuzz-sys` build scripts. This is a precursor to making sure things are actually set up correctly and clearly doing the appropriate thing.
This is an experiment to see if we're able to pick it up from pkg-config.
mrobinson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This peels 2 commits off of #211 since I think these are needed no matter what else happens.