Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the name of the GitHub Actions jobs and make sure to test all static/shared combinations #216

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Correct the name of the GitHub Actions jobs and make sure to test all static/shared combinations #216

merged 2 commits into from
Aug 18, 2023

Commits on Aug 18, 2023

  1. ci: Rename Linux jobs correctly. 

    The shared job should not disable pkg-config usage and should
be the one that does a Harfbuzz build.

The static job should disable pkg-config and should not do
its own Harfbuzz build outside of the `harfbuzz-sys` build
scripts.

This is a precursor to making sure things are actually set up
correctly and clearly doing the appropriate thing.
    @waywardmonkeys
    waywardmonkeys committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    0b4b3f4 View commit details
    Browse the repository at this point in the history

  2. ci: macOS-shared: Use harfbuzz from homebrew. 

    This is an experiment to see if we're able to pick it up from
pkg-config.
    @waywardmonkeys
    waywardmonkeys committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    32ddf4c View commit details
    Browse the repository at this point in the history