-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for memory leaks #106
Closed
Closed
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6346e99
Add tests for memory
sethmlarson 90d8530
Skip memray tests if not installed
sethmlarson fc3e952
Ignore 'limit_memory' marker not being available
sethmlarson ba3f080
Move memray posargs separately to be less confusing
sethmlarson 07b2680
Test out memory limiting to see if we can trip the limit
sethmlarson cd1ff09
Merge branch 'main' into memory-testing
sethmlarson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,3 +34,6 @@ asyncio_mode = "strict" | |
filterwarnings = [ | ||
"error", | ||
] | ||
markers = [ | ||
"limit_memory" | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import asyncio | ||
import ssl | ||
|
||
import pytest | ||
import urllib3 | ||
|
||
import truststore | ||
|
||
from .conftest import Server | ||
|
||
try: | ||
import pytest_memray # noqa: F401 | ||
|
||
memray_installed = True | ||
except ImportError: | ||
memray_installed = False | ||
|
||
|
||
@pytest.mark.skipif(not memray_installed, reason="Memray isn't installed") | ||
@pytest.mark.limit_memory("1MB") | ||
@pytest.mark.asyncio | ||
async def test_memory_limit(server: Server) -> None: | ||
def run_requests(): | ||
ctx = truststore.SSLContext(ssl.PROTOCOL_TLS_CLIENT) | ||
for _ in range(10000): | ||
with urllib3.PoolManager(ssl_context=ctx) as http: | ||
http.request("GET", server.base_url) | ||
http.clear() # Close connections so we get new ones. | ||
|
||
thread = asyncio.to_thread(run_requests) | ||
await thread |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is worth something, but for catching leaks what we care about is not the high water mark but how much RAM is still used after all tests are done...right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I was trying to figure out how we can assert that no allocations were leaked but wasn't able to immediately find anything, I see this PR which looks like what we need? Maybe I'll add a ping of @pablogsal in case there's something I'm missing from the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sethmlarson Okay yeah, that looks like the right place for it. We can follow up and add it once that PR lands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are still iterating a bit over thar PR because is quite difficult to isolate from weird one-off allocations that the interpreter does and caches. Stay tuned. Meanwhile you can use the high watermark limit + a lot of iterations of the test as a proxy if you want