Add tests for memory leaks #106
Conversation
sethmlarson
force-pushed
the
memory-testing
branch
from
6a208eb to
90d8530
Compare
|
|
||
|
|
||
| @pytest.mark.skipif(not memray_installed, reason="Memray isn't installed") | ||
| @pytest.mark.limit_memory("1MB") |
There was a problem hiding this comment.
This is worth something, but for catching leaks what we care about is not the high water mark but how much RAM is still used after all tests are done...right?
There was a problem hiding this comment.
I agree, I was trying to figure out how we can assert that no allocations were leaked but wasn't able to immediately find anything, I see this PR which looks like what we need? Maybe I'll add a ping of @pablogsal in case there's something I'm missing from the docs.
There was a problem hiding this comment.
@sethmlarson Okay yeah, that looks like the right place for it. We can follow up and add it once that PR lands.
There was a problem hiding this comment.
We are still iterating a bit over thar PR because is quite difficult to isolate from weird one-off allocations that the interpreter does and caches. Stay tuned. Meanwhile you can use the high watermark limit + a lot of iterations of the test as a proxy if you want
|
(Sorry for review dismissal, wanted to see if this test is even capable of detecting leaked memory) |
sethmlarson
force-pushed
the
memory-testing
branch
from
5af1b0a to
07b2680
Compare
|
Going to close this PR since it's stalled in case someone else wanted to try adding memray. |
Closes #104