create validation stub to facilitate parallel work on validation and message passing #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Zacholme7
reviewed
Feb 14, 2025
| use tracing::debug; | ||
|
|
||
| // TODO taken from go-SSV as rough guidance. feel free to adjust as needed. https://github.com/ssvlabs/ssv/blob/e12abf7dfbbd068b99612fa2ebbe7e3372e57280/message/validation/errors.go#L55 | ||
| pub enum ValidationFailure { |
There was a problem hiding this comment.
I see some errors in here that require qbft specific data. How do we plan on getting access to that data? or should these errors be used within qbft?
There was a problem hiding this comment.
excellent question 😅
if we really end up needing some of the internal qbft state, then this approach is too naive, and we will need some callback system for parts of the validation. We'll see. This was just a quick copy&paste.
|
Think we should just get this in or keep it as a draft for now? |
marked it as draft as #147 includes it and we can therefore just merge that. As soon as that is done, we can close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two remaining tasks for the MVP are message passing and validation. This PR enables parallel work on this by adding a stub - and creating a todo location for validation and for message passing, allowing two team members to work simultaneously on one topic each.