Add mermaid support for our mdbook #53
Closed
+2,232
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chong-he
reviewed
Nov 7, 2024
| @@ -2,5 +2,5 @@ | |||
|
|
|||
| _Documentation for protocol developers._ | |||
|
|
|||
| This section lists Lighthouse-specific decisions that are not strictly spec'd and may be useful for | |||
| This section lists Anchor-specific decisions that are not strictly spec'd and may be useful for | |||
There was a problem hiding this comment.
When I read this last time I thought this is meant to be Lighthouse, because it mentions "spec" e.g. Lighthouse has it's own API that's not on spec. But I am not sure so I didn't change it
|
Maybe we need to re-open this |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Just browsing our book and noticed we don't have mermaid support.
This adds support for mermaid diagrams, however I've had to mess with the workflow and I've not tested the new build.
This works locally, but it remains to be seen if this holds up in the CI