fix(provider): normalize openrouter model slugs in async spawn#1716
Open
darrenzeng2025 wants to merge 1 commit intosipeed:mainfrom
Open
fix(provider): normalize openrouter model slugs in async spawn#1716darrenzeng2025 wants to merge 1 commit intosipeed:mainfrom
darrenzeng2025 wants to merge 1 commit intosipeed:mainfrom
Conversation
Fix OpenRouter model normalization for nested transport-prefixed model slugs. PicoClaw could forward raw values like openrouter/minimax/minimax-m2.5 directly to OpenRouter on async spawn/subagent paths, which causes 400 invalid model ID. This change normalizes nested OpenRouter-prefixed slugs to the provider-accepted <vendor>/<model> form before the API call, while preserving special cases like openrouter/auto and openrouter/free. - Strip leading openrouter/ segment when remaining value is a nested path - Preserve openrouter/auto and openrouter/free shorthand values - Add regression tests for nested OpenRouter model refs Fixes sipeed#1678
|
I hope this is merged soon, I'm stumbled upon this bug and really like it to be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OpenRouter model normalization for nested transport-prefixed model slugs.
PicoClaw could forward raw values like
openrouter/minimax/minimax-m2.5directlyto OpenRouter on async spawn/subagent paths, which causes
400 invalid model ID.This change normalizes nested OpenRouter-prefixed slugs to the provider-accepted
\u003cvendor\u003e/\u003cmodel\u003eform before the API call, while preserving special cases likeopenrouter/autoandopenrouter/free.Changes
openrouter/segment when remaining value is a nested pathopenrouter/autoandopenrouter/freeshorthand valuesFixes #1678