Skip to content

fix(provider): normalize openrouter model slugs in async spawn #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darrenzeng2025 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(provider): normalize openrouter model slugs in async spawn #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/providers/openai_compat/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,9 @@ func normalizeModel(model, apiBase string) string {
}

if strings.Contains(strings.ToLower(apiBase), "openrouter.ai") {
if strings.EqualFold(before, "openrouter") && strings.Contains(after, "/") {
return after
}
return model
}

Expand Down
71 changes: 61 additions & 10 deletions pkg/providers/openai_compat/provider_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,17 +561,68 @@ func TestProviderChat_AcceptsNumericOptionTypes(t *testing.T) {
}

func TestNormalizeModel_UsesAPIBase(t *testing.T) {
if got := normalizeModel("deepseek/deepseek-chat", "https://api.deepseek.com/v1"); got != "deepseek-chat" {
t.Fatalf("normalizeModel(deepseek) = %q, want %q", got, "deepseek-chat")
}
if got := normalizeModel("openrouter/auto", "https://openrouter.ai/api/v1"); got != "openrouter/auto" {
t.Fatalf("normalizeModel(openrouter) = %q, want %q", got, "openrouter/auto")
}
if got := normalizeModel("vivgrid/managed", "https://api.vivgrid.com/v1"); got != "managed" {
t.Fatalf("normalizeModel(vivgrid) = %q, want %q", got, "managed")
tests := []struct {
name string
model string
apiBase string
want string
}{
{
name: "strips deepseek transport prefix",
model: "deepseek/deepseek-chat",
apiBase: "https://api.deepseek.com/v1",
want: "deepseek-chat",
},
{
name: "preserves openrouter auto shorthand",
model: "openrouter/auto",
apiBase: "https://openrouter.ai/api/v1",
want: "openrouter/auto",
},
{
name: "preserves openrouter free shorthand",
model: "openrouter/free",
apiBase: "https://openrouter.ai/api/v1",
want: "openrouter/free",
},
{
name: "strips openrouter transport prefix for nested vendor model",
model: "openrouter/openai/gpt-5.4",
apiBase: "https://openrouter.ai/api/v1",
want: "openai/gpt-5.4",
},
{
name: "strips openrouter transport prefix for any nested provider path",
model: "openrouter/stepfun/step-3.5-flash:free",
apiBase: "https://openrouter.ai/api/v1",
want: "stepfun/step-3.5-flash:free",
},
{
name: "strips openrouter transport prefix for other nested vendor model",
model: "openrouter/minimax/minimax-m2.5",
apiBase: "https://openrouter.ai/api/v1",
want: "minimax/minimax-m2.5",
},
{
name: "strips vivgrid transport prefix",
model: "vivgrid/managed",
apiBase: "https://api.vivgrid.com/v1",
want: "managed",
},
{
name: "strips vivgrid auto alias",
model: "vivgrid/auto",
apiBase: "https://api.vivgrid.com/v1",
want: "auto",
},
}
if got := normalizeModel("vivgrid/auto", "https://api.vivgrid.com/v1"); got != "auto" {
t.Fatalf("normalizeModel(vivgrid auto) = %q, want %q", got, "auto")

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := normalizeModel(tt.model, tt.apiBase); got != tt.want {
t.Fatalf("normalizeModel(%q, %q) = %q, want %q", tt.model, tt.apiBase, got, tt.want)
}
})
}
}

Expand Down
Loading